#9032: XML-RPC client: Transport.request() retries on EPIPE error
The EPIPE error occurs when the server closes the socket and the client sends a
"big" XML-RPC request (I don't know exactly the size threshold).
request() just have to ignore the error because single_request() closes the
socket on error, and so the next call to single_request() will open a new
socket.
Remove also a comment in the HTTP client because it's now wrong: see r70643
and issue #5542.
diff --git a/Lib/http/client.py b/Lib/http/client.py
index c83c53b..e4a9c07 100644
--- a/Lib/http/client.py
+++ b/Lib/http/client.py
@@ -734,11 +734,6 @@
else:
raise NotConnected()
- # send the data to the server. if we get a broken pipe, then close
- # the socket. we want to reconnect when somebody tries to send again.
- #
- # NOTE: we DO propagate the error, though, because we cannot simply
- # ignore the error... the caller will know if they can retry.
if self.debuglevel > 0:
print("send:", repr(str))
blocksize = 8192
diff --git a/Lib/xmlrpc/client.py b/Lib/xmlrpc/client.py
index a72908c..d9c43c2 100644
--- a/Lib/xmlrpc/client.py
+++ b/Lib/xmlrpc/client.py
@@ -1135,7 +1135,7 @@
try:
return self.single_request(host, handler, request_body, verbose)
except socket.error as e:
- if i or e.errno not in (errno.ECONNRESET, errno.ECONNABORTED):
+ if i or e.errno not in (errno.ECONNRESET, errno.ECONNABORTED, errno.EPIPE):
raise
except http.client.BadStatusLine: #close after we sent request
if i: