Issue #20245: The open functions in the tarfile module now correctly handle empty mode.
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index 3e054ac..49469fd 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -213,6 +213,7 @@
class MiscReadTest(CommonReadTest):
+ taropen = tarfile.TarFile.taropen
def test_no_name_argument(self):
fobj = open(self.tarname, "rb")
@@ -233,6 +234,17 @@
tar = tarfile.open(fileobj=fobj, mode=self.mode)
self.assertEqual(tar.name, None)
+ def test_illegal_mode_arg(self):
+ with open(tmpname, 'wb'):
+ pass
+ self.addCleanup(os.unlink, tmpname)
+ with self.assertRaisesRegexp(ValueError, 'mode must be '):
+ tar = self.taropen(tmpname, 'q')
+ with self.assertRaisesRegexp(ValueError, 'mode must be '):
+ tar = self.taropen(tmpname, 'rw')
+ with self.assertRaisesRegexp(ValueError, 'mode must be '):
+ tar = self.taropen(tmpname, '')
+
def test_fileobj_with_offset(self):
# Skip the first member and store values from the second member
# of the testtar.
@@ -1543,6 +1555,7 @@
class GzipMiscReadTest(MiscReadTest):
tarname = gzipname
mode = "r:gz"
+ taropen = tarfile.TarFile.gzopen
class GzipUstarReadTest(UstarReadTest):
tarname = gzipname
mode = "r:gz"
@@ -1558,6 +1571,7 @@
class Bz2MiscReadTest(MiscReadTest):
tarname = bz2name
mode = "r:bz2"
+ taropen = tarfile.TarFile.bz2open
class Bz2UstarReadTest(UstarReadTest):
tarname = bz2name
mode = "r:bz2"