Fixed memoryview constructor. It allowed arbitrary keyword arguments. The bug was found by mykhal from #python. I've also added a small test case in the new test_memoryview.py
diff --git a/Objects/memoryobject.c b/Objects/memoryobject.c
index f0a45f6..2f177c2 100644
--- a/Objects/memoryobject.c
+++ b/Objects/memoryobject.c
@@ -69,10 +69,15 @@
static PyObject *
memory_new(PyTypeObject *subtype, PyObject *args, PyObject *kwds)
{
- PyObject *obj;
- if (!PyArg_UnpackTuple(args, "memoryview", 1, 1, &obj)) return NULL;
+ PyObject *obj;
+ static char *kwlist[] = {"object", 0};
- return PyMemoryView_FromObject(obj);
+ if (!PyArg_ParseTupleAndKeywords(args, kwds, "O:memoryview", kwlist,
+ &obj)) {
+ return NULL;
+ }
+
+ return PyMemoryView_FromObject(obj);
}