commit 801f9d3888f4e2f44fe5aa7e9e46f8620a60702f
author Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> Sat Dec 27 04:21:44 2008 +0000
committer Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp> Sat Dec 27 04:21:44 2008 +0000
tree 2f03e47c1ac595cb6db3fdeb1c5354753b2d0307
parent 81d90a220f2cea407e261a3c884d388a084d2d1e

Issue #4740: Use HIGHEST_PROTOCOL in pickle test. This enables test for protocol 3
(== HIGHEST_PROTOCOL in 3.x)

Lib/test/test_array.py

diff --git a/Lib/test/test_array.py b/Lib/test/test_array.py
index 5a505de..2b80a7d 100755
--- a/Lib/test/test_array.py
+++ b/Lib/test/test_array.py
@@ -7,7 +7,7 @@
 from test import support
 from weakref import proxy
 import array, io, math
-from pickle import loads, dumps
+from pickle import loads, dumps, HIGHEST_PROTOCOL
 import operator
 
 class ArraySubclass(array.array):
@@ -98,7 +98,7 @@
         self.assertEqual(a, b)
 
     def test_pickle(self):
-        for protocol in (0, 1, 2):
+        for protocol in range(HIGHEST_PROTOCOL + 1):
             a = array.array(self.typecode, self.example)
             b = loads(dumps(a, protocol))
             self.assertNotEqual(id(a), id(b))
@@ -113,7 +113,7 @@
             self.assertEqual(type(a), type(b))
 
     def test_pickle_for_empty_array(self):
-        for protocol in (0, 1, 2):
+        for protocol in range(HIGHEST_PROTOCOL + 1):
             a = array.array(self.typecode)
             b = loads(dumps(a, protocol))
             self.assertNotEqual(id(a), id(b))

Lib/test/test_deque.py

diff --git a/Lib/test/test_deque.py b/Lib/test/test_deque.py
index 1ac43da..7af0803 100644
--- a/Lib/test/test_deque.py
+++ b/Lib/test/test_deque.py
@@ -375,7 +375,7 @@
 
     def test_pickle(self):
         d = deque(range(200))
-        for i in (0, 1, 2):
+        for i in range(pickle.HIGHEST_PROTOCOL + 1):
             s = pickle.dumps(d, i)
             e = pickle.loads(s)
             self.assertNotEqual(id(d), id(e))
@@ -384,7 +384,7 @@
 ##    def test_pickle_recursive(self):
 ##        d = deque('abc')
 ##        d.append(d)
-##        for i in (0, 1, 2):
+##        for i in range(pickle.HIGHEST_PROTOCOL + 1):
 ##            e = pickle.loads(pickle.dumps(d, i))
 ##            self.assertNotEqual(id(d), id(e))
 ##            self.assertEqual(id(e), id(e[-1]))

Lib/test/test_set.py

diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
index 07319fc..da3ed0f 100644
--- a/Lib/test/test_set.py
+++ b/Lib/test/test_set.py
@@ -219,7 +219,7 @@
         self.failIf(set('cbs').issuperset('a'))
 
     def test_pickling(self):
-        for i in (0, 1, 2):
+        for i in range(pickle.HIGHEST_PROTOCOL + 1):
             p = pickle.dumps(self.s, i)
             dup = pickle.loads(p)
             self.assertEqual(self.s, dup, "%s != %s" % (self.s, dup))