commit 816a5ff3b218ac374f89bf3cda0d13f47b7bd92e
author Serhiy Storchaka <storchaka@gmail.com> Sat May 07 15:41:09 2016 +0300
committer Serhiy Storchaka <storchaka@gmail.com> Sat May 07 15:41:09 2016 +0300
tree 4c97c70fda3f69c42196da80fd7dcea299c65e0b
parent b4905efe23c3e158a3c494d40988ce6de6bde3cd

Issue #17765: weakref.ref() no longer silently ignores keyword arguments.
Patch by Georg Brandl.

Objects/weakrefobject.c

diff --git a/Objects/weakrefobject.c b/Objects/weakrefobject.c
index e1f4bc4..c8b982f 100644
--- a/Objects/weakrefobject.c
+++ b/Objects/weakrefobject.c
@@ -271,7 +271,6 @@
 parse_weakref_init_args(char *funcname, PyObject *args, PyObject *kwargs,
                         PyObject **obp, PyObject **callbackp)
 {
-    /* XXX Should check that kwargs == NULL or is empty. */
     return PyArg_UnpackTuple(args, funcname, 1, 2, obp, callbackp);
 }
 
@@ -334,6 +333,9 @@
 {
     PyObject *tmp;
 
+    if (!_PyArg_NoKeywords("ref()", kwargs))
+        return -1;
+
     if (parse_weakref_init_args("__init__", args, kwargs, &tmp, &tmp))
         return 0;
     else