commit 81971eafbef55f635413ed530beb4a6651c68549
author Benjamin Peterson <benjamin@python.org> Thu May 14 22:01:31 2009 +0000
committer Benjamin Peterson <benjamin@python.org> Thu May 14 22:01:31 2009 +0000
tree b4c62f8c86b55e4ba3370e7cdc34e5231c39d58e
parent 37d1c18bda0e1596c465c75f8fe928400899399a

correctly handle invalid operations on streams (like writing on a non-writable one)

Modules/_io/textio.c

diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
index 8d2a686..b78256e 100644
--- a/Modules/_io/textio.c
+++ b/Modules/_io/textio.c
@@ -1228,6 +1228,11 @@
 
     CHECK_CLOSED(self);
 
+    if (self->encoder == NULL) {
+        PyErr_SetString(PyExc_IOError, "not writable");
+        return NULL;
+    }
+
     Py_INCREF(text);
 
     textlen = PyUnicode_GetSize(text);
@@ -1363,7 +1368,7 @@
      */
 
     if (self->decoder == NULL) {
-        PyErr_SetString(PyExc_ValueError, "no decoder");
+        PyErr_SetString(PyExc_IOError, "not readable");
         return -1;
     }