Add XXX comments for whoever cleans up getargs.c :)
diff --git a/Python/getargs.c b/Python/getargs.c
index abe0887..1370e09 100644
--- a/Python/getargs.c
+++ b/Python/getargs.c
@@ -823,6 +823,9 @@
}
else
return converterr("string", arg, msgbuf, bufsize);
+ /* XXX(gb): this test is completely wrong -- p is a
+ * byte string while arg is a Unicode. I *think* it should
+ * check against the size of uarg... */
if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
return converterr("string without null bytes",
arg, msgbuf, bufsize);
@@ -898,6 +901,7 @@
}
format++;
}
+ /* XXX(gb): same comment as for 's' applies here... */
else if (*p != NULL &&
(Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg))
return converterr(