Fix for the unfortunate fact that PyDict_GetItem and PyObject_GetItem
have differing refcount semantics. If anyone sees a prettier way to
acheive the same ends, then please go for it.
I think this is the first time I've ever used Py_XINCREF.
diff --git a/Python/ceval.c b/Python/ceval.c
index 3a462af..6c457e1 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -1742,8 +1742,10 @@
PyObject_REPR(w));
break;
}
- if (PyDict_CheckExact(v))
+ if (PyDict_CheckExact(v)) {
x = PyDict_GetItem(v, w);
+ Py_XINCREF(x);
+ }
else {
x = PyObject_GetItem(v, w);
if (x == NULL && PyErr_Occurred()) {
@@ -1763,8 +1765,8 @@
break;
}
}
+ Py_INCREF(x);
}
- Py_INCREF(x);
PUSH(x);
continue;