Issue #12451: Open files in binary mode in some tests when the text file is not
needed.
Remove also an unused variable (blank) in test_threading.
diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
index f58a5c1..af02939 100644
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -689,12 +689,11 @@
class DevNullTests(unittest.TestCase):
def test_devnull(self):
- f = open(os.devnull, 'w')
- f.write('hello')
- f.close()
- f = open(os.devnull, 'r')
- self.assertEqual(f.read(), '')
- f.close()
+ with open(os.devnull, 'wb') as f:
+ f.write(b'hello')
+ f.close()
+ with open(os.devnull, 'rb') as f:
+ self.assertEqual(f.read(), b'')
class URandomTests(unittest.TestCase):
def test_urandom(self):
@@ -1044,7 +1043,7 @@
def test_open(self):
for fn in self.unicodefn:
- f = open(os.path.join(self.dir, fn))
+ f = open(os.path.join(self.dir, fn), 'rb')
f.close()
def test_stat(self):