commit bcd304480f16f3f936a7bdbff4dfab41f8e30292
author Hynek Schlawack <hs@ox.cx> Mon Jun 04 14:19:39 2012 +0200
committer Hynek Schlawack <hs@ox.cx> Mon Jun 04 14:19:39 2012 +0200
tree 3cd394791b9352fc3fca8a4f106fa1f375f1ce9c
parent 7d74effc67281b505756e040437241e5b1436a7c

#14814: Use correct comparison for IP addresses

ipaddress._BaseV4.is_unspecified() compared IP addresses using "in" which
fails.

Lib/ipaddress.py

diff --git a/Lib/ipaddress.py b/Lib/ipaddress.py
index a8edcd1..25bcccd 100644
--- a/Lib/ipaddress.py
+++ b/Lib/ipaddress.py
@@ -1130,7 +1130,7 @@
         """
         unspecified_address = IPv4Address('0.0.0.0')
         if isinstance(self, _BaseAddress):
-            return self in unspecified_address
+            return self == unspecified_address
         return (self.network_address == self.broadcast_address ==
                 unspecified_address)
 

Lib/test/test_ipaddress.py

diff --git a/Lib/test/test_ipaddress.py b/Lib/test/test_ipaddress.py
index aff4ff9..5b7d013 100644
--- a/Lib/test/test_ipaddress.py
+++ b/Lib/test/test_ipaddress.py
@@ -837,6 +837,7 @@
         self.assertEqual(False, ipaddress.ip_network('128.0.0.0').is_loopback)
 
         # test addresses
+        self.assertEqual(True, ipaddress.ip_address('0.0.0.0').is_unspecified)
         self.assertEqual(True, ipaddress.ip_address('224.1.1.1').is_multicast)
         self.assertEqual(False, ipaddress.ip_address('240.0.0.0').is_multicast)