Cleanup xmlrpc: remove obsolete comments, unused imports. Add test for bytes marshalling.
diff --git a/Lib/xmlrpc/client.py b/Lib/xmlrpc/client.py
index 9312344..bd59f32 100644
--- a/Lib/xmlrpc/client.py
+++ b/Lib/xmlrpc/client.py
@@ -85,11 +85,6 @@
# OF THIS SOFTWARE.
# --------------------------------------------------------------------
-#
-# things to look into some day:
-
-# TODO: sort out True/False/boolean issues for Python 2.3
-
"""
An XML-RPC client interface for Python.
@@ -120,8 +115,7 @@
Exported constants:
- True
- False
+ (none)
Exported functions:
@@ -133,7 +127,8 @@
name (None if not present).
"""
-import re, time, operator
+import base64
+import time
import http.client
from xml.parsers import expat
import socket
@@ -230,7 +225,7 @@
##
# Indicates an XML-RPC fault response package. This exception is
# raised by the unmarshalling layer, if the XML-RPC response contains
-# a fault string. This exception can also used as a class, to
+# a fault string. This exception can also be used as a class, to
# generate a fault XML-RPC message.
#
# @param faultCode The XML-RPC fault code.
@@ -243,10 +238,7 @@
self.faultCode = faultCode
self.faultString = faultString
def __repr__(self):
- return (
- "<Fault %s: %s>" %
- (self.faultCode, repr(self.faultString))
- )
+ return "<Fault %s: %r>" % (self.faultCode, self.faultString)
# --------------------------------------------------------------------
# Special values
@@ -352,7 +344,7 @@
return self.value
def __repr__(self):
- return "<DateTime %s at %x>" % (repr(self.value), id(self))
+ return "<DateTime %r at %x>" % (self.value, id(self))
def decode(self, data):
self.value = str(data).strip()
@@ -378,9 +370,6 @@
#
# @param data An 8-bit string containing arbitrary data.
-import base64
-import io
-
class Binary:
"""Wrapper for binary data."""
@@ -1198,7 +1187,6 @@
auth, host = urllib.parse.splituser(host)
if auth:
- import base64
auth = urllib.parse.unquote_to_bytes(auth)
auth = base64.encodebytes(auth).decode("utf-8")
auth = "".join(auth.split()) # get rid of whitespace