commit cac0b83b3583986eae4b84299e023af32e719b95
author Mark Dickinson <dickinsm@gmail.com> Sun Jul 18 07:55:55 2010 +0000
committer Mark Dickinson <dickinsm@gmail.com> Sun Jul 18 07:55:55 2010 +0000
tree 03da19dde599447d6c5a8497bd5e3697db55c732
parent 5dba6dfe6a8224a54c3a4fd5cc2393a734718a77

Merged revisions 82941,82943 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k

........
  r82941 | mark.dickinson | 2010-07-18 08:29:02 +0100 (Sun, 18 Jul 2010) | 3 lines

  Issue #9277: Struct module: standard bool packing was incorrect if
  char is unsigned.  Thanks Stefan Krah for the patch.
........
  r82943 | mark.dickinson | 2010-07-18 08:48:20 +0100 (Sun, 18 Jul 2010) | 1 line

  Misc/NEWS entry for r82941.
........

Modules/_struct.c

diff --git a/Modules/_struct.c b/Modules/_struct.c
index 52c5eeb..f22c31c 100644
--- a/Modules/_struct.c
+++ b/Modules/_struct.c
@@ -912,11 +912,11 @@
 static int
 bp_bool(char *p, PyObject *v, const formatdef *f)
 {
-    char y;
+    int y;
     y = PyObject_IsTrue(v);
     if (y < 0)
         return -1;
-    memcpy(p, (char *)&y, sizeof y);
+    *p = (char)y;
     return 0;
 }