commit cff22eb2bfde08b000c476e121eef551a5e3af6c
author Martin Panter <vadmium+py@gmail.com> Sat Oct 03 05:38:07 2015 +0000
committer Martin Panter <vadmium+py@gmail.com> Sat Oct 03 05:38:07 2015 +0000
tree 02dc41afccb8aa2ac0847df499d2dd9cecf665e1
parent 195fc2f2aa5edd5958a46f8d129aa16cf6c51a2d

Issue #25232: Fix CGIRequestHandler's splitting of URL query

Patch from Xiang Zhang.

Lib/CGIHTTPServer.py

diff --git a/Lib/CGIHTTPServer.py b/Lib/CGIHTTPServer.py
index 8f8ae56..7a4593e 100644
--- a/Lib/CGIHTTPServer.py
+++ b/Lib/CGIHTTPServer.py
@@ -120,11 +120,7 @@
                 break
 
         # find an explicit query string, if present.
-        i = rest.rfind('?')
-        if i >= 0:
-            rest, query = rest[:i], rest[i+1:]
-        else:
-            query = ''
+        rest, _, query = rest.partition('?')
 
         # dissect the part after the directory name into a script name &
         # a possible additional path, to be stored in PATH_INFO.