backport rev. 54207: add a few sanity checks in unittest.TestSuite.addTest(s).
diff --git a/Lib/unittest.py b/Lib/unittest.py
index cde23d8..cd91c2c 100644
--- a/Lib/unittest.py
+++ b/Lib/unittest.py
@@ -411,9 +411,18 @@
return cases
def addTest(self, test):
+ # sanity checks
+ if not callable(test):
+ raise TypeError("the test to add must be callable")
+ if (isinstance(test, (type, types.ClassType)) and
+ issubclass(test, (TestCase, TestSuite))):
+ raise TypeError("TestCases and TestSuites must be instantiated "
+ "before passing them to addTest()")
self._tests.append(test)
def addTests(self, tests):
+ if isinstance(tests, basestring):
+ raise TypeError("tests must be an iterable of tests, not a string")
for test in tests:
self.addTest(test)