socketserver renaming reversal part 3: move the module into the right
place and fix all references to it. Closes #2926.
diff --git a/Lib/BaseHTTPServer.py b/Lib/BaseHTTPServer.py
index cc244a7..5f2d558 100644
--- a/Lib/BaseHTTPServer.py
+++ b/Lib/BaseHTTPServer.py
@@ -74,7 +74,7 @@
import time
import socket # For gethostbyaddr()
import mimetools
-import socketserver
+import SocketServer
# Default error message template
DEFAULT_ERROR_MESSAGE = """\
@@ -94,19 +94,19 @@
def _quote_html(html):
return html.replace("&", "&").replace("<", "<").replace(">", ">")
-class HTTPServer(socketserver.TCPServer):
+class HTTPServer(SocketServer.TCPServer):
allow_reuse_address = 1 # Seems to make sense in testing environment
def server_bind(self):
"""Override server_bind to store the server name."""
- socketserver.TCPServer.server_bind(self)
+ SocketServer.TCPServer.server_bind(self)
host, port = self.socket.getsockname()[:2]
self.server_name = socket.getfqdn(host)
self.server_port = port
-class BaseHTTPRequestHandler(socketserver.StreamRequestHandler):
+class BaseHTTPRequestHandler(SocketServer.StreamRequestHandler):
"""HTTP request handler base class.
diff --git a/Lib/SimpleXMLRPCServer.py b/Lib/SimpleXMLRPCServer.py
index 353542a..5fad0af 100644
--- a/Lib/SimpleXMLRPCServer.py
+++ b/Lib/SimpleXMLRPCServer.py
@@ -101,7 +101,7 @@
import xmlrpclib
from xmlrpclib import Fault
-import socketserver
+import SocketServer
import BaseHTTPServer
import sys
import os
@@ -512,7 +512,7 @@
if self.server.logRequests:
BaseHTTPServer.BaseHTTPRequestHandler.log_request(self, code, size)
-class SimpleXMLRPCServer(socketserver.TCPServer,
+class SimpleXMLRPCServer(SocketServer.TCPServer,
SimpleXMLRPCDispatcher):
"""Simple XML-RPC server.
@@ -536,7 +536,7 @@
self.logRequests = logRequests
SimpleXMLRPCDispatcher.__init__(self, allow_none, encoding)
- socketserver.TCPServer.__init__(self, addr, requestHandler, bind_and_activate)
+ SocketServer.TCPServer.__init__(self, addr, requestHandler, bind_and_activate)
# [Bug #1222790] If possible, set close-on-exec flag; if a
# method spawns a subprocess, the subprocess shouldn't have
diff --git a/Lib/lib-old/SocketServer.py b/Lib/SocketServer.py
similarity index 100%
rename from Lib/lib-old/SocketServer.py
rename to Lib/SocketServer.py
diff --git a/Lib/idlelib/rpc.py b/Lib/idlelib/rpc.py
index e0bcf2c..cdfdac4 100644
--- a/Lib/idlelib/rpc.py
+++ b/Lib/idlelib/rpc.py
@@ -5,7 +5,7 @@
has only one client per server, this was not a limitation.
+---------------------------------+ +-------------+
- | socketserver.BaseRequestHandler | | SocketIO |
+ | SocketServer.BaseRequestHandler | | SocketIO |
+---------------------------------+ +-------------+
^ | register() |
| | unregister()|
@@ -31,7 +31,7 @@
import os
import socket
import select
-import socketserver
+import SocketServer
import struct
import cPickle as pickle
import threading
@@ -66,12 +66,12 @@
BUFSIZE = 8*1024
LOCALHOST = '127.0.0.1'
-class RPCServer(socketserver.TCPServer):
+class RPCServer(SocketServer.TCPServer):
def __init__(self, addr, handlerclass=None):
if handlerclass is None:
handlerclass = RPCHandler
- socketserver.TCPServer.__init__(self, addr, handlerclass)
+ SocketServer.TCPServer.__init__(self, addr, handlerclass)
def server_bind(self):
"Override TCPServer method, no bind() phase for connecting entity"
@@ -492,7 +492,7 @@
def __init__(self, oid):
self.oid = oid
-class RPCHandler(socketserver.BaseRequestHandler, SocketIO):
+class RPCHandler(SocketServer.BaseRequestHandler, SocketIO):
debugging = False
location = "#S" # Server
@@ -500,10 +500,10 @@
def __init__(self, sock, addr, svr):
svr.current_handler = self ## cgt xxx
SocketIO.__init__(self, sock)
- socketserver.BaseRequestHandler.__init__(self, sock, addr, svr)
+ SocketServer.BaseRequestHandler.__init__(self, sock, addr, svr)
def handle(self):
- "handle() method required by socketserver"
+ "handle() method required by SocketServer"
self.mainloop()
def get_remote_proxy(self, oid):
diff --git a/Lib/logging/config.py b/Lib/logging/config.py
index b4c52b4..dc13723 100644
--- a/Lib/logging/config.py
+++ b/Lib/logging/config.py
@@ -35,7 +35,7 @@
except ImportError:
thread = None
-from socketserver import ThreadingTCPServer, StreamRequestHandler
+from SocketServer import ThreadingTCPServer, StreamRequestHandler
DEFAULT_LOGGING_CONFIG_PORT = 9030
diff --git a/Lib/test/test___all__.py b/Lib/test/test___all__.py
index 846a2f6..ec58c14 100644
--- a/Lib/test/test___all__.py
+++ b/Lib/test/test___all__.py
@@ -42,7 +42,7 @@
self.check_all("MimeWriter")
self.check_all("queue")
self.check_all("SimpleHTTPServer")
- self.check_all("socketserver")
+ self.check_all("SocketServer")
self.check_all("StringIO")
self.check_all("UserString")
self.check_all("aifc")
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 97e1af3..b937411 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -33,7 +33,7 @@
import re
import select
import socket
-from socketserver import ThreadingTCPServer, StreamRequestHandler
+from SocketServer import ThreadingTCPServer, StreamRequestHandler
import string
import struct
import sys
diff --git a/Lib/test/test_py3kwarn.py b/Lib/test/test_py3kwarn.py
index b12d14d..5a9421f 100644
--- a/Lib/test/test_py3kwarn.py
+++ b/Lib/test/test_py3kwarn.py
@@ -216,7 +216,6 @@
class TestStdlibRenames(unittest.TestCase):
renames = {'Queue': 'queue',
- 'SocketServer': 'socketserver',
'ConfigParser': 'configparser',
}
diff --git a/Lib/test/test_socketserver.py b/Lib/test/test_socketserver.py
index 4e26e7b..8595e5a 100644
--- a/Lib/test/test_socketserver.py
+++ b/Lib/test/test_socketserver.py
@@ -1,5 +1,5 @@
"""
-Test suite for socketserver.
+Test suite for SocketServer.py.
"""
import contextlib
@@ -13,7 +13,7 @@
import threading
import time
import unittest
-import socketserver
+import SocketServer
import test.test_support
from test.test_support import reap_children, verbose, TestSkipped
@@ -40,12 +40,12 @@
raise RuntimeError, "timed out on %r" % (sock,)
if HAVE_UNIX_SOCKETS:
- class ForkingUnixStreamServer(socketserver.ForkingMixIn,
- socketserver.UnixStreamServer):
+ class ForkingUnixStreamServer(SocketServer.ForkingMixIn,
+ SocketServer.UnixStreamServer):
pass
- class ForkingUnixDatagramServer(socketserver.ForkingMixIn,
- socketserver.UnixDatagramServer):
+ class ForkingUnixDatagramServer(SocketServer.ForkingMixIn,
+ SocketServer.UnixDatagramServer):
pass
@@ -172,55 +172,55 @@
s.close()
def test_TCPServer(self):
- self.run_server(socketserver.TCPServer,
- socketserver.StreamRequestHandler,
+ self.run_server(SocketServer.TCPServer,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
def test_ThreadingTCPServer(self):
- self.run_server(socketserver.ThreadingTCPServer,
- socketserver.StreamRequestHandler,
+ self.run_server(SocketServer.ThreadingTCPServer,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
if HAVE_FORKING:
def test_ForkingTCPServer(self):
with simple_subprocess(self):
- self.run_server(socketserver.ForkingTCPServer,
- socketserver.StreamRequestHandler,
+ self.run_server(SocketServer.ForkingTCPServer,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
if HAVE_UNIX_SOCKETS:
def test_UnixStreamServer(self):
- self.run_server(socketserver.UnixStreamServer,
- socketserver.StreamRequestHandler,
+ self.run_server(SocketServer.UnixStreamServer,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
def test_ThreadingUnixStreamServer(self):
- self.run_server(socketserver.ThreadingUnixStreamServer,
- socketserver.StreamRequestHandler,
+ self.run_server(SocketServer.ThreadingUnixStreamServer,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
if HAVE_FORKING:
def test_ForkingUnixStreamServer(self):
with simple_subprocess(self):
self.run_server(ForkingUnixStreamServer,
- socketserver.StreamRequestHandler,
+ SocketServer.StreamRequestHandler,
self.stream_examine)
def test_UDPServer(self):
- self.run_server(socketserver.UDPServer,
- socketserver.DatagramRequestHandler,
+ self.run_server(SocketServer.UDPServer,
+ SocketServer.DatagramRequestHandler,
self.dgram_examine)
def test_ThreadingUDPServer(self):
- self.run_server(socketserver.ThreadingUDPServer,
- socketserver.DatagramRequestHandler,
+ self.run_server(SocketServer.ThreadingUDPServer,
+ SocketServer.DatagramRequestHandler,
self.dgram_examine)
if HAVE_FORKING:
def test_ForkingUDPServer(self):
with simple_subprocess(self):
- self.run_server(socketserver.ForkingUDPServer,
- socketserver.DatagramRequestHandler,
+ self.run_server(SocketServer.ForkingUDPServer,
+ SocketServer.DatagramRequestHandler,
self.dgram_examine)
# Alas, on Linux (at least) recvfrom() doesn't return a meaningful
@@ -228,19 +228,19 @@
# if HAVE_UNIX_SOCKETS:
# def test_UnixDatagramServer(self):
- # self.run_server(socketserver.UnixDatagramServer,
- # socketserver.DatagramRequestHandler,
+ # self.run_server(SocketServer.UnixDatagramServer,
+ # SocketServer.DatagramRequestHandler,
# self.dgram_examine)
#
# def test_ThreadingUnixDatagramServer(self):
- # self.run_server(socketserver.ThreadingUnixDatagramServer,
- # socketserver.DatagramRequestHandler,
+ # self.run_server(SocketServer.ThreadingUnixDatagramServer,
+ # SocketServer.DatagramRequestHandler,
# self.dgram_examine)
#
# if HAVE_FORKING:
# def test_ForkingUnixDatagramServer(self):
- # self.run_server(socketserver.ForkingUnixDatagramServer,
- # socketserver.DatagramRequestHandler,
+ # self.run_server(SocketServer.ForkingUnixDatagramServer,
+ # SocketServer.DatagramRequestHandler,
# self.dgram_examine)
diff --git a/Lib/test/test_wsgiref.py b/Lib/test/test_wsgiref.py
index e30990e..b6d994b 100755
--- a/Lib/test/test_wsgiref.py
+++ b/Lib/test/test_wsgiref.py
@@ -8,7 +8,7 @@
from wsgiref.simple_server import WSGIServer, WSGIRequestHandler, demo_app
from wsgiref.simple_server import make_server
from StringIO import StringIO
-from socketserver import BaseServer
+from SocketServer import BaseServer
import re, sys
from test import test_support