commit e350c840b389f645b25f00f1fa35f6ea1fec03b3
author Martin v. Löwis <martin@v.loewis.de> Sat Nov 18 18:05:57 2006 +0000
committer Martin v. Löwis <martin@v.loewis.de> Sat Nov 18 18:05:57 2006 +0000
tree 63dbfc8e4e619f68aa7c302f144bfb2e17071c76
parent ce9212f018fbd074aba7a37cef4291ebd2e428d4

Patch #1594554: Always close a tkSimpleDialog on ok(), even
if an exception occurs.

Lib/lib-tk/tkSimpleDialog.py

diff --git a/Lib/lib-tk/tkSimpleDialog.py b/Lib/lib-tk/tkSimpleDialog.py
index 02ea034..4450484 100644
--- a/Lib/lib-tk/tkSimpleDialog.py
+++ b/Lib/lib-tk/tkSimpleDialog.py
@@ -129,9 +129,10 @@
         self.withdraw()
         self.update_idletasks()
 
-        self.apply()
-
-        self.cancel()
+        try:
+            self.apply()
+        finally:
+            self.cancel()
 
     def cancel(self, event=None):
 

Misc/NEWS

diff --git a/Misc/NEWS b/Misc/NEWS
index 6e50ed3..5b98155 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -103,6 +103,9 @@
 Library
 -------
 
+- Patch #1594554: Always close a tkSimpleDialog on ok(), even
+  if an exception occurs.
+
 - Patch #1538878: Don't make tkSimpleDialog dialogs transient if
   the parent window is withdrawn.