commit e7a0d3997846155e1a9dcd95eb559039da34ee08
author Guido van Rossum <guido@python.org> Thu Jul 12 07:53:00 2007 +0000
committer Guido van Rossum <guido@python.org> Thu Jul 12 07:53:00 2007 +0000
tree 53e7fcc4736ebf9dc57b3099abac613a2eef3b12
parent dc09715d0bb43a8e7d0a33486e3f07976309df12

Fixed a refcount leak in _PyUnicode_AsDefaultEncodedString().
Found by Amaury Forgeot d'Arc, SF# 1752317.
(Also removed a redundant check for !errors.)

Objects/unicodeobject.c

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index 47b1d6c..2728f1f 100644
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -1206,10 +1206,7 @@
     v = PyString_FromStringAndSize(PyBytes_AsString(b),
                                    PyBytes_Size(b));
     Py_DECREF(b);
-    if (!errors) {
-        Py_XINCREF(v);
-        ((PyUnicodeObject *)unicode)->defenc = v;
-    }
+    ((PyUnicodeObject *)unicode)->defenc = v;
     return v;
 }