tree 7376032573207f5df59e599efa32bfccbafb7153
parent ded1c4df0b98b05af22d82bd8ae8795f7c8da916
author Andrew M. Kuchling <amk@amk.ca> 1166644100 +0000
committer Andrew M. Kuchling <amk@amk.ca> 1166644100 +0000
HG:extra convert_revision:svn%3A6015fed2-1504-0410-9fe1-9d1591cc4771/python/branches/legacy-trunk%4053110

[Apply length-checking.diff from bug #1599254]

Add length checking to single-file mailbox formats: before doing a
flush() on a mailbox, seek to the end and verify its length is
unchanged, raising ExternalClashError if the file's length has
changed.

This fix avoids potential data loss if some other process appends to
the mailbox file after the table of contents has been generated;
instead of overwriting the modified file, you'll get the exception.

I also noticed that the self._lookup() call in self.flush() wasn't
necessary (everything that sets self._pending to True also calls
self.lookup()), and replaced it by an assertion.

2.5 backport candidate.