Merged revisions 88460 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r88460 | antoine.pitrou | 2011-02-21 19:03:13 +0100 (lun., 21 févr. 2011) | 4 lines
Issue #10276: Fix the results of zlib.crc32() and zlib.adler32() on buffers
larger than 4GB. Patch by Nadeem Vawda.
........
diff --git a/Lib/test/test_zlib.py b/Lib/test/test_zlib.py
index 5615c2d..9aafffa 100644
--- a/Lib/test/test_zlib.py
+++ b/Lib/test/test_zlib.py
@@ -2,10 +2,16 @@
from test import support
import binascii
import random
+import sys
from test.support import precisionbigmemtest, _1G, _4G
zlib = support.import_module('zlib')
+try:
+ import mmap
+except ImportError:
+ mmap = None
+
class ChecksumTestCase(unittest.TestCase):
# checksum test cases
@@ -57,6 +63,28 @@
self.assertEqual(binascii.crc32(b'spam'), zlib.crc32(b'spam'))
+# Issue #10276 - check that inputs >=4GB are handled correctly.
+class ChecksumBigBufferTestCase(unittest.TestCase):
+
+ def setUp(self):
+ with open(support.TESTFN, "wb+") as f:
+ f.seek(_4G)
+ f.write(b"asdf")
+ f.flush()
+ self.mapping = mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ)
+
+ def tearDown(self):
+ self.mapping.close()
+ support.unlink(support.TESTFN)
+
+ @unittest.skipUnless(mmap, "mmap() is not available.")
+ @unittest.skipUnless(sys.maxsize > _4G, "Can't run on a 32-bit system.")
+ @unittest.skipUnless(support.is_resource_enabled("largefile"),
+ "May use lots of disk space.")
+ def test_big_buffer(self):
+ self.assertEqual(zlib.crc32(self.mapping), 3058686908)
+ self.assertEqual(zlib.adler32(self.mapping), 82837919)
+
class ExceptionTestCase(unittest.TestCase):
# make sure we generate some expected errors
@@ -577,6 +605,7 @@
def test_main():
support.run_unittest(
ChecksumTestCase,
+ ChecksumBigBufferTestCase,
ExceptionTestCase,
CompressTestCase,
CompressObjectTestCase