bpo-32110: codecs.StreamReader.read(n) now returns not more than n (GH-4499) (#4623)
characters/bytes for non-negative n. This makes it compatible with
read() methods of other file-like objects.
(cherry picked from commit 219c2de5ad0fdac825298bed1bb251f16956c04a)
diff --git a/Lib/test/test_codecs.py b/Lib/test/test_codecs.py
index efc40cf..0ec8bf5 100644
--- a/Lib/test/test_codecs.py
+++ b/Lib/test/test_codecs.py
@@ -149,19 +149,33 @@
self.assertEqual(f.read(), ''.join(lines[1:]))
self.assertEqual(f.read(), '')
+ # Issue #32110: Test readline() followed by read(n)
+ f = getreader()
+ self.assertEqual(f.readline(), lines[0])
+ self.assertEqual(f.read(1), lines[1][0])
+ self.assertEqual(f.read(0), '')
+ self.assertEqual(f.read(100), data[len(lines[0]) + 1:][:100])
+
# Issue #16636: Test readline() followed by readlines()
f = getreader()
self.assertEqual(f.readline(), lines[0])
self.assertEqual(f.readlines(), lines[1:])
self.assertEqual(f.read(), '')
- # Test read() followed by read()
+ # Test read(n) followed by read()
f = getreader()
self.assertEqual(f.read(size=40, chars=5), data[:5])
self.assertEqual(f.read(), data[5:])
self.assertEqual(f.read(), '')
- # Issue #12446: Test read() followed by readlines()
+ # Issue #32110: Test read(n) followed by read(n)
+ f = getreader()
+ self.assertEqual(f.read(size=40, chars=5), data[:5])
+ self.assertEqual(f.read(1), data[5])
+ self.assertEqual(f.read(0), '')
+ self.assertEqual(f.read(100), data[6:106])
+
+ # Issue #12446: Test read(n) followed by readlines()
f = getreader()
self.assertEqual(f.read(size=40, chars=5), data[:5])
self.assertEqual(f.readlines(), [lines[0][5:]] + lines[1:])