#6750: TextIOWrapped could duplicate output when several threads write to it.
this affect text files opened with io.open(), and the print() function of py3k
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
index c129303..3b627f2 100644
--- a/Modules/_io/textio.c
+++ b/Modules/_io/textio.c
@@ -1189,11 +1189,18 @@
static int
_textiowrapper_writeflush(textio *self)
{
- PyObject *b, *ret;
+ PyObject *pending, *b, *ret;
if (self->pending_bytes == NULL)
return 0;
- b = _PyBytes_Join(_PyIO_empty_bytes, self->pending_bytes);
+
+ pending = self->pending_bytes;
+ Py_INCREF(pending);
+ self->pending_bytes_count = 0;
+ Py_CLEAR(self->pending_bytes);
+
+ b = _PyBytes_Join(_PyIO_empty_bytes, pending);
+ Py_DECREF(pending);
if (b == NULL)
return -1;
ret = PyObject_CallMethodObjArgs(self->buffer,
@@ -1202,8 +1209,6 @@
if (ret == NULL)
return -1;
Py_DECREF(ret);
- Py_CLEAR(self->pending_bytes);
- self->pending_bytes_count = 0;
return 0;
}