blob: a51eb716b493846bdab02c716db9e9b2cb9c9a58 [file] [log] [blame]
Martin v. Löwis5e37bae2008-03-19 04:43:46 +00001# Copyright 2006 Google, Inc. All Rights Reserved.
2# Licensed to PSF under a Contributor Agreement.
3
4"""Refactoring framework.
5
6Used as a main program, this can refactor any number of files and/or
7recursively descend down directories. Imported as a module, this
8provides infrastructure to write your own refactoring tool.
9"""
10
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +000011from __future__ import with_statement
12
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000013__author__ = "Guido van Rossum <guido@python.org>"
14
15
16# Python imports
17import os
18import sys
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000019import logging
Benjamin Petersoneb55fd82008-09-03 00:21:32 +000020import operator
Benjamin Peterson840077c2009-07-20 15:33:09 +000021import collections
22import StringIO
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000023from itertools import chain
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000024
25# Local imports
Benjamin Peterson840077c2009-07-20 15:33:09 +000026from .pgen2 import driver, tokenize, token
Benjamin Petersona81eae12010-10-14 23:00:00 +000027from .fixer_util import find_root
Benjamin Peterson61180402009-06-11 22:06:46 +000028from . import pytree, pygram
Benjamin Petersona81eae12010-10-14 23:00:00 +000029from . import btm_utils as bu
30from . import btm_matcher as bm
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000031
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000032
Benjamin Petersoneb55fd82008-09-03 00:21:32 +000033def get_all_fix_names(fixer_pkg, remove_prefix=True):
34 """Return a sorted list of all available fix names in the given package."""
35 pkg = __import__(fixer_pkg, [], [], ["*"])
36 fixer_dir = os.path.dirname(pkg.__file__)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000037 fix_names = []
Benjamin Peterson6ae94ee2008-10-15 23:10:28 +000038 for name in sorted(os.listdir(fixer_dir)):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000039 if name.startswith("fix_") and name.endswith(".py"):
Benjamin Petersoneb55fd82008-09-03 00:21:32 +000040 if remove_prefix:
41 name = name[4:]
42 fix_names.append(name[:-3])
Martin v. Löwis5e37bae2008-03-19 04:43:46 +000043 return fix_names
44
Benjamin Peterson840077c2009-07-20 15:33:09 +000045
46class _EveryNode(Exception):
47 pass
48
49
50def _get_head_types(pat):
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000051 """ Accepts a pytree Pattern Node and returns a set
52 of the pattern types which will match first. """
53
54 if isinstance(pat, (pytree.NodePattern, pytree.LeafPattern)):
55 # NodePatters must either have no type and no content
56 # or a type and content -- so they don't get any farther
57 # Always return leafs
Benjamin Peterson840077c2009-07-20 15:33:09 +000058 if pat.type is None:
59 raise _EveryNode
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000060 return set([pat.type])
61
62 if isinstance(pat, pytree.NegatedPattern):
63 if pat.content:
Benjamin Peterson840077c2009-07-20 15:33:09 +000064 return _get_head_types(pat.content)
65 raise _EveryNode # Negated Patterns don't have a type
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000066
67 if isinstance(pat, pytree.WildcardPattern):
68 # Recurse on each node in content
69 r = set()
70 for p in pat.content:
71 for x in p:
Benjamin Peterson840077c2009-07-20 15:33:09 +000072 r.update(_get_head_types(x))
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000073 return r
74
75 raise Exception("Oh no! I don't understand pattern %s" %(pat))
76
Benjamin Peterson840077c2009-07-20 15:33:09 +000077
78def _get_headnode_dict(fixer_list):
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000079 """ Accepts a list of fixers and returns a dictionary
80 of head node type --> fixer list. """
Benjamin Peterson840077c2009-07-20 15:33:09 +000081 head_nodes = collections.defaultdict(list)
82 every = []
Martin v. Löwis6780a9d2008-05-02 21:30:20 +000083 for fixer in fixer_list:
Benjamin Peterson840077c2009-07-20 15:33:09 +000084 if fixer.pattern:
85 try:
86 heads = _get_head_types(fixer.pattern)
87 except _EveryNode:
88 every.append(fixer)
89 else:
90 for node_type in heads:
91 head_nodes[node_type].append(fixer)
92 else:
93 if fixer._accept_type is not None:
94 head_nodes[fixer._accept_type].append(fixer)
95 else:
96 every.append(fixer)
97 for node_type in chain(pygram.python_grammar.symbol2number.itervalues(),
98 pygram.python_grammar.tokens):
99 head_nodes[node_type].extend(every)
100 return dict(head_nodes)
101
Martin v. Löwis6780a9d2008-05-02 21:30:20 +0000102
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000103def get_fixers_from_package(pkg_name):
104 """
105 Return the fully qualified names for fixers in the package pkg_name.
106 """
107 return [pkg_name + "." + fix_name
108 for fix_name in get_all_fix_names(pkg_name, False)]
109
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000110def _identity(obj):
111 return obj
112
113if sys.version_info < (3, 0):
114 import codecs
115 _open_with_encoding = codecs.open
116 # codecs.open doesn't translate newlines sadly.
117 def _from_system_newlines(input):
118 return input.replace(u"\r\n", u"\n")
119 def _to_system_newlines(input):
120 if os.linesep != "\n":
121 return input.replace(u"\n", os.linesep)
122 else:
123 return input
124else:
125 _open_with_encoding = open
126 _from_system_newlines = _identity
127 _to_system_newlines = _identity
128
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000129
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000130def _detect_future_features(source):
Benjamin Peterson840077c2009-07-20 15:33:09 +0000131 have_docstring = False
132 gen = tokenize.generate_tokens(StringIO.StringIO(source).readline)
133 def advance():
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000134 tok = gen.next()
Benjamin Peterson840077c2009-07-20 15:33:09 +0000135 return tok[0], tok[1]
136 ignore = frozenset((token.NEWLINE, tokenize.NL, token.COMMENT))
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000137 features = set()
Benjamin Peterson840077c2009-07-20 15:33:09 +0000138 try:
139 while True:
140 tp, value = advance()
141 if tp in ignore:
142 continue
143 elif tp == token.STRING:
144 if have_docstring:
145 break
146 have_docstring = True
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000147 elif tp == token.NAME and value == u"from":
148 tp, value = advance()
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000149 if tp != token.NAME or value != u"__future__":
Benjamin Peterson840077c2009-07-20 15:33:09 +0000150 break
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000151 tp, value = advance()
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000152 if tp != token.NAME or value != u"import":
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000153 break
154 tp, value = advance()
155 if tp == token.OP and value == u"(":
156 tp, value = advance()
157 while tp == token.NAME:
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000158 features.add(value)
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000159 tp, value = advance()
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000160 if tp != token.OP or value != u",":
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000161 break
162 tp, value = advance()
Benjamin Peterson840077c2009-07-20 15:33:09 +0000163 else:
164 break
165 except StopIteration:
166 pass
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000167 return frozenset(features)
Benjamin Peterson840077c2009-07-20 15:33:09 +0000168
169
Benjamin Peterson08be2912008-09-27 21:09:10 +0000170class FixerError(Exception):
171 """A fixer could not be loaded."""
172
173
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000174class RefactoringTool(object):
175
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000176 _default_options = {"print_function" : False}
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000177
Benjamin Peterson08be2912008-09-27 21:09:10 +0000178 CLASS_PREFIX = "Fix" # The prefix for fixer classes
179 FILE_PREFIX = "fix_" # The prefix for modules with a fixer within
180
181 def __init__(self, fixer_names, options=None, explicit=None):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000182 """Initializer.
183
Benjamin Petersone6078232008-06-15 02:31:05 +0000184 Args:
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000185 fixer_names: a list of fixers to import
186 options: an dict with configuration.
187 explicit: a list of fixers to run even if they are explicit.
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000188 """
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000189 self.fixers = fixer_names
Benjamin Peterson08be2912008-09-27 21:09:10 +0000190 self.explicit = explicit or []
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000191 self.options = self._default_options.copy()
192 if options is not None:
193 self.options.update(options)
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000194 if self.options["print_function"]:
195 self.grammar = pygram.python_grammar_no_print_statement
196 else:
197 self.grammar = pygram.python_grammar
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000198 self.errors = []
199 self.logger = logging.getLogger("RefactoringTool")
200 self.fixer_log = []
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000201 self.wrote = False
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000202 self.driver = driver.Driver(self.grammar,
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000203 convert=pytree.convert,
204 logger=self.logger)
205 self.pre_order, self.post_order = self.get_fixers()
Martin v. Löwis6780a9d2008-05-02 21:30:20 +0000206
Martin v. Löwis6780a9d2008-05-02 21:30:20 +0000207
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000208 self.files = [] # List of files that were or should be modified
209
Benjamin Petersona81eae12010-10-14 23:00:00 +0000210 self.BM = bm.BottomMatcher()
211 self.bmi_pre_order = [] # Bottom Matcher incompatible fixers
212 self.bmi_post_order = []
213
214 for fixer in chain(self.post_order, self.pre_order):
215 if fixer.BM_compatible:
216 self.BM.add_fixer(fixer)
217 # remove fixers that will be handled by the bottom-up
218 # matcher
219 elif fixer in self.pre_order:
220 self.bmi_pre_order.append(fixer)
221 elif fixer in self.post_order:
222 self.bmi_post_order.append(fixer)
223
224 self.bmi_pre_order_heads = _get_headnode_dict(self.bmi_pre_order)
225 self.bmi_post_order_heads = _get_headnode_dict(self.bmi_post_order)
226
227
228
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000229 def get_fixers(self):
230 """Inspects the options to load the requested patterns and handlers.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000231
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000232 Returns:
233 (pre_order, post_order), where pre_order is the list of fixers that
234 want a pre-order AST traversal, and post_order is the list that want
235 post-order traversal.
236 """
237 pre_order_fixers = []
238 post_order_fixers = []
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000239 for fix_mod_path in self.fixers:
Benjamin Peterson08be2912008-09-27 21:09:10 +0000240 mod = __import__(fix_mod_path, {}, {}, ["*"])
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000241 fix_name = fix_mod_path.rsplit(".", 1)[-1]
Benjamin Peterson08be2912008-09-27 21:09:10 +0000242 if fix_name.startswith(self.FILE_PREFIX):
243 fix_name = fix_name[len(self.FILE_PREFIX):]
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000244 parts = fix_name.split("_")
Benjamin Peterson08be2912008-09-27 21:09:10 +0000245 class_name = self.CLASS_PREFIX + "".join([p.title() for p in parts])
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000246 try:
247 fix_class = getattr(mod, class_name)
248 except AttributeError:
Benjamin Peterson08be2912008-09-27 21:09:10 +0000249 raise FixerError("Can't find %s.%s" % (fix_name, class_name))
250 fixer = fix_class(self.options, self.fixer_log)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000251 if fixer.explicit and self.explicit is not True and \
252 fix_mod_path not in self.explicit:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000253 self.log_message("Skipping implicit fixer: %s", fix_name)
254 continue
255
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000256 self.log_debug("Adding transformation: %s", fix_name)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000257 if fixer.order == "pre":
258 pre_order_fixers.append(fixer)
259 elif fixer.order == "post":
260 post_order_fixers.append(fixer)
261 else:
Benjamin Peterson08be2912008-09-27 21:09:10 +0000262 raise FixerError("Illegal fixer order: %r" % fixer.order)
Martin v. Löwisbaf267c2008-03-22 00:01:12 +0000263
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000264 key_func = operator.attrgetter("run_order")
265 pre_order_fixers.sort(key=key_func)
266 post_order_fixers.sort(key=key_func)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000267 return (pre_order_fixers, post_order_fixers)
268
269 def log_error(self, msg, *args, **kwds):
Benjamin Peterson08be2912008-09-27 21:09:10 +0000270 """Called when an error occurs."""
271 raise
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000272
273 def log_message(self, msg, *args):
274 """Hook to log a message."""
275 if args:
276 msg = msg % args
277 self.logger.info(msg)
278
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000279 def log_debug(self, msg, *args):
280 if args:
281 msg = msg % args
282 self.logger.debug(msg)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000283
Benjamin Peterson840077c2009-07-20 15:33:09 +0000284 def print_output(self, old_text, new_text, filename, equal):
285 """Called with the old version, new version, and filename of a
286 refactored file."""
Benjamin Peterson08be2912008-09-27 21:09:10 +0000287 pass
288
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000289 def refactor(self, items, write=False, doctests_only=False):
290 """Refactor a list of files and directories."""
Benjamin Petersona81eae12010-10-14 23:00:00 +0000291
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000292 for dir_or_file in items:
293 if os.path.isdir(dir_or_file):
Benjamin Peterson08be2912008-09-27 21:09:10 +0000294 self.refactor_dir(dir_or_file, write, doctests_only)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000295 else:
Benjamin Peterson08be2912008-09-27 21:09:10 +0000296 self.refactor_file(dir_or_file, write, doctests_only)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000297
298 def refactor_dir(self, dir_name, write=False, doctests_only=False):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000299 """Descends down a directory and refactor every Python file found.
300
301 Python files are assumed to have a .py extension.
302
303 Files and subdirectories starting with '.' are skipped.
304 """
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000305 for dirpath, dirnames, filenames in os.walk(dir_name):
306 self.log_debug("Descending into %s", dirpath)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000307 dirnames.sort()
308 filenames.sort()
309 for name in filenames:
Benjamin Peterson840077c2009-07-20 15:33:09 +0000310 if not name.startswith(".") and \
311 os.path.splitext(name)[1].endswith("py"):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000312 fullname = os.path.join(dirpath, name)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000313 self.refactor_file(fullname, write, doctests_only)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000314 # Modify dirnames in-place to remove subdirs with leading dots
315 dirnames[:] = [dn for dn in dirnames if not dn.startswith(".")]
316
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000317 def _read_python_source(self, filename):
318 """
319 Do our best to decode a Python source file correctly.
320 """
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000321 try:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000322 f = open(filename, "rb")
Benjamin Petersona81eae12010-10-14 23:00:00 +0000323 except IOError as err:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000324 self.log_error("Can't open %s: %s", filename, err)
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000325 return None, None
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000326 try:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000327 encoding = tokenize.detect_encoding(f.readline)[0]
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000328 finally:
329 f.close()
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000330 with _open_with_encoding(filename, "r", encoding=encoding) as f:
331 return _from_system_newlines(f.read()), encoding
332
333 def refactor_file(self, filename, write=False, doctests_only=False):
334 """Refactors a file."""
335 input, encoding = self._read_python_source(filename)
336 if input is None:
337 # Reading the file failed.
338 return
339 input += u"\n" # Silence certain parse errors
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000340 if doctests_only:
341 self.log_debug("Refactoring doctests in %s", filename)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000342 output = self.refactor_docstring(input, filename)
343 if output != input:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000344 self.processed_file(output, filename, input, write, encoding)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000345 else:
346 self.log_debug("No doctest changes in %s", filename)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000347 else:
348 tree = self.refactor_string(input, filename)
349 if tree and tree.was_changed:
350 # The [:-1] is to take off the \n we added earlier
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000351 self.processed_file(unicode(tree)[:-1], filename,
352 write=write, encoding=encoding)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000353 else:
354 self.log_debug("No changes in %s", filename)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000355
356 def refactor_string(self, data, name):
357 """Refactor a given input string.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000358
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000359 Args:
360 data: a string holding the code to be refactored.
361 name: a human-readable name for use in error/log messages.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000362
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000363 Returns:
364 An AST corresponding to the refactored input stream; None if
365 there were errors during the parse.
366 """
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000367 features = _detect_future_features(data)
368 if "print_function" in features:
Benjamin Peterson840077c2009-07-20 15:33:09 +0000369 self.driver.grammar = pygram.python_grammar_no_print_statement
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000370 try:
Benjamin Peterson6ae94ee2008-10-15 23:10:28 +0000371 tree = self.driver.parse_string(data)
Benjamin Petersona81eae12010-10-14 23:00:00 +0000372 except Exception as err:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000373 self.log_error("Can't parse %s: %s: %s",
374 name, err.__class__.__name__, err)
375 return
Benjamin Peterson840077c2009-07-20 15:33:09 +0000376 finally:
Benjamin Peterson42d26d92009-11-25 18:16:46 +0000377 self.driver.grammar = self.grammar
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000378 tree.future_features = features
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000379 self.log_debug("Refactoring %s", name)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000380 self.refactor_tree(tree, name)
381 return tree
382
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000383 def refactor_stdin(self, doctests_only=False):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000384 input = sys.stdin.read()
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000385 if doctests_only:
386 self.log_debug("Refactoring doctests in stdin")
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000387 output = self.refactor_docstring(input, "<stdin>")
388 if output != input:
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000389 self.processed_file(output, "<stdin>", input)
390 else:
391 self.log_debug("No doctest changes in stdin")
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000392 else:
393 tree = self.refactor_string(input, "<stdin>")
394 if tree and tree.was_changed:
Benjamin Peterson840077c2009-07-20 15:33:09 +0000395 self.processed_file(unicode(tree), "<stdin>", input)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000396 else:
397 self.log_debug("No changes in stdin")
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000398
399 def refactor_tree(self, tree, name):
400 """Refactors a parse tree (modifying the tree in place).
Martin v. Löwisab41b372008-03-19 05:22:42 +0000401
Benjamin Petersona81eae12010-10-14 23:00:00 +0000402 For compatible patterns the bottom matcher module is
403 used. Otherwise the tree is traversed node-to-node for
404 matches.
405
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000406 Args:
407 tree: a pytree.Node instance representing the root of the tree
408 to be refactored.
409 name: a human-readable name for this tree.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000410
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000411 Returns:
412 True if the tree was modified, False otherwise.
413 """
Benjamin Petersona81eae12010-10-14 23:00:00 +0000414
Benjamin Peterson37fc8232009-01-03 16:34:02 +0000415 for fixer in chain(self.pre_order, self.post_order):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000416 fixer.start_tree(tree, name)
417
Benjamin Petersona81eae12010-10-14 23:00:00 +0000418 #use traditional matching for the incompatible fixers
419 self.traverse_by(self.bmi_pre_order_heads, tree.pre_order())
420 self.traverse_by(self.bmi_post_order_heads, tree.post_order())
421
422 # obtain a set of candidate nodes
423 match_set = self.BM.run(tree.leaves())
424
425 while any(match_set.values()):
426 for fixer in self.BM.fixers:
427 if fixer in match_set and match_set[fixer]:
428 #sort by depth; apply fixers from bottom(of the AST) to top
429 match_set[fixer].sort(key=pytree.Base.depth, reverse=True)
430
431 if fixer.keep_line_order:
432 #some fixers(eg fix_imports) must be applied
433 #with the original file's line order
434 match_set[fixer].sort(key=pytree.Base.get_lineno)
435
436 for node in list(match_set[fixer]):
437 if node in match_set[fixer]:
438 match_set[fixer].remove(node)
439
440 try:
441 find_root(node)
442 except AssertionError:
443 # this node has been cut off from a
444 # previous transformation ; skip
445 continue
446
447 if node.fixers_applied and fixer in node.fixers_applied:
448 # do not apply the same fixer again
449 continue
450
451 results = fixer.match(node)
452
453 if results:
454 new = fixer.transform(node, results)
455 if new is not None:
456 node.replace(new)
457 #new.fixers_applied.append(fixer)
458 for node in new.post_order():
459 # do not apply the fixer again to
460 # this or any subnode
461 if not node.fixers_applied:
462 node.fixers_applied = []
463 node.fixers_applied.append(fixer)
464
465 # update the original match set for
466 # the added code
467 new_matches = self.BM.run(new.leaves())
468 for fxr in new_matches:
469 if not fxr in match_set:
470 match_set[fxr]=[]
471
472 match_set[fxr].extend(new_matches[fxr])
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000473
Benjamin Peterson37fc8232009-01-03 16:34:02 +0000474 for fixer in chain(self.pre_order, self.post_order):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000475 fixer.finish_tree(tree, name)
476 return tree.was_changed
477
478 def traverse_by(self, fixers, traversal):
479 """Traverse an AST, applying a set of fixers to each node.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000480
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000481 This is a helper method for refactor_tree().
Martin v. Löwisab41b372008-03-19 05:22:42 +0000482
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000483 Args:
484 fixers: a list of fixer instances.
485 traversal: a generator that yields AST nodes.
Martin v. Löwisab41b372008-03-19 05:22:42 +0000486
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000487 Returns:
488 None
489 """
490 if not fixers:
491 return
492 for node in traversal:
Benjamin Peterson840077c2009-07-20 15:33:09 +0000493 for fixer in fixers[node.type]:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000494 results = fixer.match(node)
495 if results:
496 new = fixer.transform(node, results)
Benjamin Peterson840077c2009-07-20 15:33:09 +0000497 if new is not None:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000498 node.replace(new)
499 node = new
500
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000501 def processed_file(self, new_text, filename, old_text=None, write=False,
502 encoding=None):
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000503 """
504 Called when a file has been refactored, and there are changes.
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000505 """
506 self.files.append(filename)
507 if old_text is None:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000508 old_text = self._read_python_source(filename)[0]
509 if old_text is None:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000510 return
Benjamin Peterson840077c2009-07-20 15:33:09 +0000511 equal = old_text == new_text
512 self.print_output(old_text, new_text, filename, equal)
513 if equal:
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000514 self.log_debug("No changes to %s", filename)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000515 return
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000516 if write:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000517 self.write_file(new_text, filename, old_text, encoding)
Benjamin Peterson08be2912008-09-27 21:09:10 +0000518 else:
519 self.log_debug("Not writing changes to %s", filename)
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000520
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000521 def write_file(self, new_text, filename, old_text, encoding=None):
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000522 """Writes a string to a file.
523
524 It first shows a unified diff between the old text and the new text, and
525 then rewrites the file; the latter is only done if the write option is
526 set.
527 """
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000528 try:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000529 f = _open_with_encoding(filename, "w", encoding=encoding)
Benjamin Petersona81eae12010-10-14 23:00:00 +0000530 except os.error as err:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000531 self.log_error("Can't create %s: %s", filename, err)
532 return
533 try:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000534 f.write(_to_system_newlines(new_text))
Benjamin Petersona81eae12010-10-14 23:00:00 +0000535 except os.error as err:
Benjamin Petersonba4d4802008-11-10 22:11:12 +0000536 self.log_error("Can't write %s: %s", filename, err)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000537 finally:
538 f.close()
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000539 self.log_debug("Wrote changes to %s", filename)
540 self.wrote = True
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000541
542 PS1 = ">>> "
543 PS2 = "... "
544
545 def refactor_docstring(self, input, filename):
546 """Refactors a docstring, looking for doctests.
547
548 This returns a modified version of the input string. It looks
549 for doctests, which start with a ">>>" prompt, and may be
550 continued with "..." prompts, as long as the "..." is indented
551 the same as the ">>>".
552
553 (Unfortunately we can't use the doctest module's parser,
554 since, like most parsers, it is not geared towards preserving
555 the original source.)
556 """
557 result = []
558 block = None
559 block_lineno = None
560 indent = None
561 lineno = 0
562 for line in input.splitlines(True):
563 lineno += 1
564 if line.lstrip().startswith(self.PS1):
565 if block is not None:
566 result.extend(self.refactor_doctest(block, block_lineno,
567 indent, filename))
568 block_lineno = lineno
569 block = [line]
570 i = line.find(self.PS1)
571 indent = line[:i]
572 elif (indent is not None and
573 (line.startswith(indent + self.PS2) or
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000574 line == indent + self.PS2.rstrip() + u"\n")):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000575 block.append(line)
576 else:
577 if block is not None:
578 result.extend(self.refactor_doctest(block, block_lineno,
579 indent, filename))
580 block = None
581 indent = None
582 result.append(line)
583 if block is not None:
584 result.extend(self.refactor_doctest(block, block_lineno,
585 indent, filename))
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000586 return u"".join(result)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000587
588 def refactor_doctest(self, block, lineno, indent, filename):
589 """Refactors one doctest.
590
591 A doctest is given as a block of lines, the first of which starts
592 with ">>>" (possibly indented), while the remaining lines start
593 with "..." (identically indented).
594
595 """
596 try:
597 tree = self.parse_block(block, lineno, indent)
Benjamin Petersona81eae12010-10-14 23:00:00 +0000598 except Exception as err:
Benjamin Peterson6eccb792010-08-08 19:13:06 +0000599 if self.logger.isEnabledFor(logging.DEBUG):
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000600 for line in block:
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000601 self.log_debug("Source: %s", line.rstrip(u"\n"))
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000602 self.log_error("Can't parse docstring in %s line %s: %s: %s",
603 filename, lineno, err.__class__.__name__, err)
604 return block
605 if self.refactor_tree(tree, filename):
Benjamin Peterson840077c2009-07-20 15:33:09 +0000606 new = unicode(tree).splitlines(True)
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000607 # Undo the adjustment of the line numbers in wrap_toks() below.
608 clipped, new = new[:lineno-1], new[lineno-1:]
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000609 assert clipped == [u"\n"] * (lineno-1), clipped
610 if not new[-1].endswith(u"\n"):
611 new[-1] += u"\n"
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000612 block = [indent + self.PS1 + new.pop(0)]
613 if new:
614 block += [indent + self.PS2 + line for line in new]
615 return block
616
617 def summarize(self):
Benjamin Petersoneb55fd82008-09-03 00:21:32 +0000618 if self.wrote:
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000619 were = "were"
620 else:
621 were = "need to be"
622 if not self.files:
623 self.log_message("No files %s modified.", were)
624 else:
625 self.log_message("Files that %s modified:", were)
626 for file in self.files:
627 self.log_message(file)
628 if self.fixer_log:
629 self.log_message("Warnings/messages while refactoring:")
630 for message in self.fixer_log:
631 self.log_message(message)
632 if self.errors:
633 if len(self.errors) == 1:
634 self.log_message("There was 1 error:")
635 else:
636 self.log_message("There were %d errors:", len(self.errors))
637 for msg, args, kwds in self.errors:
638 self.log_message(msg, *args, **kwds)
639
640 def parse_block(self, block, lineno, indent):
641 """Parses a block into a tree.
642
643 This is necessary to get correct line number / offset information
644 in the parser diagnostics and embedded into the parse tree.
645 """
Benjamin Peterson36cd75a2010-05-22 18:52:21 +0000646 tree = self.driver.parse_tokens(self.wrap_toks(block, lineno, indent))
647 tree.future_features = frozenset()
648 return tree
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000649
650 def wrap_toks(self, block, lineno, indent):
651 """Wraps a tokenize stream to systematically modify start/end."""
652 tokens = tokenize.generate_tokens(self.gen_lines(block, indent).next)
653 for type, value, (line0, col0), (line1, col1), line_text in tokens:
654 line0 += lineno - 1
655 line1 += lineno - 1
656 # Don't bother updating the columns; this is too complicated
657 # since line_text would also have to be updated and it would
658 # still break for tokens spanning lines. Let the user guess
659 # that the column numbers for doctests are relative to the
660 # end of the prompt string (PS1 or PS2).
661 yield type, value, (line0, col0), (line1, col1), line_text
662
663
664 def gen_lines(self, block, indent):
665 """Generates lines as expected by tokenize from a list of lines.
666
667 This strips the first len(indent + self.PS1) characters off each line.
668 """
669 prefix1 = indent + self.PS1
670 prefix2 = indent + self.PS2
671 prefix = prefix1
672 for line in block:
673 if line.startswith(prefix):
674 yield line[len(prefix):]
Benjamin Peterson84ad84e2009-05-09 01:01:14 +0000675 elif line == prefix.rstrip() + u"\n":
676 yield u"\n"
Martin v. Löwis5e37bae2008-03-19 04:43:46 +0000677 else:
678 raise AssertionError("line=%r, prefix=%r" % (line, prefix))
679 prefix = prefix2
680 while True:
681 yield ""
682
683
Benjamin Petersoneaeb4c62009-05-05 23:13:58 +0000684class MultiprocessingUnsupported(Exception):
685 pass
686
687
688class MultiprocessRefactoringTool(RefactoringTool):
689
690 def __init__(self, *args, **kwargs):
691 super(MultiprocessRefactoringTool, self).__init__(*args, **kwargs)
692 self.queue = None
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000693 self.output_lock = None
Benjamin Petersoneaeb4c62009-05-05 23:13:58 +0000694
695 def refactor(self, items, write=False, doctests_only=False,
696 num_processes=1):
697 if num_processes == 1:
698 return super(MultiprocessRefactoringTool, self).refactor(
699 items, write, doctests_only)
700 try:
701 import multiprocessing
702 except ImportError:
703 raise MultiprocessingUnsupported
704 if self.queue is not None:
705 raise RuntimeError("already doing multiple processes")
706 self.queue = multiprocessing.JoinableQueue()
Benjamin Peterson5dfad9d2010-05-07 18:58:23 +0000707 self.output_lock = multiprocessing.Lock()
Benjamin Petersoneaeb4c62009-05-05 23:13:58 +0000708 processes = [multiprocessing.Process(target=self._child)
709 for i in xrange(num_processes)]
710 try:
711 for p in processes:
712 p.start()
713 super(MultiprocessRefactoringTool, self).refactor(items, write,
714 doctests_only)
715 finally:
716 self.queue.join()
717 for i in xrange(num_processes):
718 self.queue.put(None)
719 for p in processes:
720 if p.is_alive():
721 p.join()
722 self.queue = None
723
724 def _child(self):
725 task = self.queue.get()
726 while task is not None:
727 args, kwargs = task
728 try:
729 super(MultiprocessRefactoringTool, self).refactor_file(
730 *args, **kwargs)
731 finally:
732 self.queue.task_done()
733 task = self.queue.get()
734
735 def refactor_file(self, *args, **kwargs):
736 if self.queue is not None:
737 self.queue.put((args, kwargs))
738 else:
739 return super(MultiprocessRefactoringTool, self).refactor_file(
740 *args, **kwargs)