Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 1 | import unittest |
Brett Cannon | 977eb02 | 2008-03-19 17:37:43 +0000 | [diff] [blame] | 2 | import sys |
Benjamin Peterson | bec087f | 2009-03-26 21:10:30 +0000 | [diff] [blame] | 3 | from test.test_support import check_warnings, CleanImport, run_unittest |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 4 | import warnings |
| 5 | |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 6 | from contextlib import nested |
| 7 | |
Brett Cannon | 977eb02 | 2008-03-19 17:37:43 +0000 | [diff] [blame] | 8 | if not sys.py3kwarning: |
Benjamin Peterson | bec087f | 2009-03-26 21:10:30 +0000 | [diff] [blame] | 9 | raise unittest.SkipTest('%s must be run with the -3 flag' % __name__) |
Brett Cannon | 977eb02 | 2008-03-19 17:37:43 +0000 | [diff] [blame] | 10 | |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 11 | def reset_module_registry(module): |
| 12 | try: |
| 13 | registry = module.__warningregistry__ |
| 14 | except AttributeError: |
| 15 | pass |
| 16 | else: |
| 17 | registry.clear() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 18 | |
| 19 | class TestPy3KWarnings(unittest.TestCase): |
| 20 | |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 21 | def assertWarning(self, _, warning, expected_message): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 22 | self.assertEqual(str(warning.message), expected_message) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 23 | |
Benjamin Peterson | 1bf4765 | 2009-07-02 17:06:17 +0000 | [diff] [blame] | 24 | def assertNoWarning(self, _, recorder): |
| 25 | self.assertEqual(len(recorder.warnings), 0) |
| 26 | |
Benjamin Peterson | 2fe3ef8 | 2008-06-08 02:05:33 +0000 | [diff] [blame] | 27 | def test_backquote(self): |
| 28 | expected = 'backquote not supported in 3.x; use repr()' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 29 | with check_warnings() as w: |
Benjamin Peterson | 2fe3ef8 | 2008-06-08 02:05:33 +0000 | [diff] [blame] | 30 | exec "`2`" in {} |
| 31 | self.assertWarning(None, w, expected) |
| 32 | |
Benjamin Peterson | 99a5023 | 2009-11-19 22:54:57 +0000 | [diff] [blame] | 33 | def test_paren_arg_names(self): |
| 34 | expected = 'parenthesized argument names are invalid in 3.x' |
| 35 | def check(s): |
| 36 | exec s in {} |
| 37 | self.assertWarning(None, w, expected) |
| 38 | with check_warnings() as w: |
| 39 | check("def f((x)): pass") |
| 40 | check("def f((((x))), (y)): pass") |
| 41 | check("def f((x), (((y))), m=32): pass") |
| 42 | # Something like def f((a, (b))): pass will raise the tuple |
| 43 | # unpacking warning. |
| 44 | |
Benjamin Peterson | 399b1fe | 2008-10-25 02:53:28 +0000 | [diff] [blame] | 45 | def test_forbidden_names(self): |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 46 | # So we don't screw up our globals |
| 47 | def safe_exec(expr): |
| 48 | def f(**kwargs): pass |
| 49 | exec expr in {'f' : f} |
| 50 | |
Benjamin Peterson | 399b1fe | 2008-10-25 02:53:28 +0000 | [diff] [blame] | 51 | tests = [("True", "assignment to True or False is forbidden in 3.x"), |
| 52 | ("False", "assignment to True or False is forbidden in 3.x"), |
| 53 | ("nonlocal", "nonlocal is a keyword in 3.x")] |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 54 | with check_warnings() as w: |
Benjamin Peterson | 399b1fe | 2008-10-25 02:53:28 +0000 | [diff] [blame] | 55 | for keyword, expected in tests: |
| 56 | safe_exec("{0} = False".format(keyword)) |
| 57 | self.assertWarning(None, w, expected) |
| 58 | w.reset() |
| 59 | try: |
| 60 | safe_exec("obj.{0} = True".format(keyword)) |
| 61 | except NameError: |
| 62 | pass |
| 63 | self.assertWarning(None, w, expected) |
| 64 | w.reset() |
| 65 | safe_exec("def {0}(): pass".format(keyword)) |
| 66 | self.assertWarning(None, w, expected) |
| 67 | w.reset() |
| 68 | safe_exec("class {0}: pass".format(keyword)) |
| 69 | self.assertWarning(None, w, expected) |
| 70 | w.reset() |
| 71 | safe_exec("def f({0}=43): pass".format(keyword)) |
| 72 | self.assertWarning(None, w, expected) |
| 73 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 74 | |
| 75 | |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 76 | def test_type_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 77 | expected = 'type inequality comparisons not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 78 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 79 | self.assertWarning(int < str, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 80 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 81 | self.assertWarning(type < object, w, expected) |
| 82 | |
| 83 | def test_object_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 84 | expected = 'comparing unequal types not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 85 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 86 | self.assertWarning(str < [], w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 87 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 88 | self.assertWarning(object() < (1, 2), w, expected) |
| 89 | |
| 90 | def test_dict_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 91 | expected = 'dict inequality comparisons not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 92 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 93 | self.assertWarning({} < {2:3}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 94 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 95 | self.assertWarning({} <= {}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 96 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 97 | self.assertWarning({} > {2:3}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 98 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 99 | self.assertWarning({2:3} >= {}, w, expected) |
| 100 | |
| 101 | def test_cell_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 102 | expected = 'cell comparisons not supported in 3.x' |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 103 | def f(x): |
| 104 | def g(): |
| 105 | return x |
| 106 | return g |
| 107 | cell0, = f(0).func_closure |
| 108 | cell1, = f(1).func_closure |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 109 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 110 | self.assertWarning(cell0 == cell1, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 111 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 112 | self.assertWarning(cell0 < cell1, w, expected) |
| 113 | |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 114 | def test_code_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 115 | expected = 'code inequality comparisons not supported in 3.x' |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 116 | def f(x): |
| 117 | pass |
| 118 | def g(x): |
| 119 | pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 120 | with check_warnings() as w: |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 121 | self.assertWarning(f.func_code < g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 122 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 123 | self.assertWarning(f.func_code <= g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 124 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 125 | self.assertWarning(f.func_code >= g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 126 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 127 | self.assertWarning(f.func_code > g.func_code, w, expected) |
| 128 | |
| 129 | def test_builtin_function_or_method_comparisons(self): |
| 130 | expected = ('builtin_function_or_method ' |
Benjamin Peterson | 1bf4765 | 2009-07-02 17:06:17 +0000 | [diff] [blame] | 131 | 'order comparisons not supported in 3.x') |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 132 | func = eval |
| 133 | meth = {}.get |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 134 | with check_warnings() as w: |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 135 | self.assertWarning(func < meth, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 136 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 137 | self.assertWarning(func > meth, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 138 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 139 | self.assertWarning(meth <= func, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 140 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 141 | self.assertWarning(meth >= func, w, expected) |
Benjamin Peterson | 1bf4765 | 2009-07-02 17:06:17 +0000 | [diff] [blame] | 142 | w.reset() |
| 143 | self.assertNoWarning(meth == func, w) |
| 144 | self.assertNoWarning(meth != func, w) |
| 145 | lam = lambda x: x |
| 146 | self.assertNoWarning(lam == func, w) |
| 147 | self.assertNoWarning(lam != func, w) |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 148 | |
Benjamin Peterson | f09925d | 2008-12-22 20:16:25 +0000 | [diff] [blame] | 149 | def test_frame_attributes(self): |
| 150 | template = "%s has been removed in 3.x" |
| 151 | f = sys._getframe(0) |
| 152 | for attr in ("f_exc_traceback", "f_exc_value", "f_exc_type"): |
| 153 | expected = template % attr |
| 154 | with check_warnings() as w: |
| 155 | self.assertWarning(getattr(f, attr), w, expected) |
| 156 | w.reset() |
| 157 | self.assertWarning(setattr(f, attr, None), w, expected) |
| 158 | |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 159 | def test_sort_cmp_arg(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 160 | expected = "the cmp argument is not supported in 3.x" |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 161 | lst = range(5) |
| 162 | cmp = lambda x,y: -1 |
| 163 | |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 164 | with check_warnings() as w: |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 165 | self.assertWarning(lst.sort(cmp=cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 166 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 167 | self.assertWarning(sorted(lst, cmp=cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 168 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 169 | self.assertWarning(lst.sort(cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 170 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 171 | self.assertWarning(sorted(lst, cmp), w, expected) |
| 172 | |
Georg Brandl | 5a44424 | 2008-03-21 20:11:46 +0000 | [diff] [blame] | 173 | def test_sys_exc_clear(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 174 | expected = 'sys.exc_clear() not supported in 3.x; use except clauses' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 175 | with check_warnings() as w: |
Georg Brandl | 5a44424 | 2008-03-21 20:11:46 +0000 | [diff] [blame] | 176 | self.assertWarning(sys.exc_clear(), w, expected) |
| 177 | |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 178 | def test_methods_members(self): |
| 179 | expected = '__members__ and __methods__ not supported in 3.x' |
| 180 | class C: |
| 181 | __methods__ = ['a'] |
| 182 | __members__ = ['b'] |
| 183 | c = C() |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 184 | with check_warnings() as w: |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 185 | self.assertWarning(dir(c), w, expected) |
| 186 | |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 187 | def test_softspace(self): |
| 188 | expected = 'file.softspace not supported in 3.x' |
| 189 | with file(__file__) as f: |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 190 | with check_warnings() as w: |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 191 | self.assertWarning(f.softspace, w, expected) |
| 192 | def set(): |
| 193 | f.softspace = 0 |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 194 | with check_warnings() as w: |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 195 | self.assertWarning(set(), w, expected) |
| 196 | |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 197 | def test_slice_methods(self): |
| 198 | class Spam(object): |
| 199 | def __getslice__(self, i, j): pass |
| 200 | def __setslice__(self, i, j, what): pass |
| 201 | def __delslice__(self, i, j): pass |
| 202 | class Egg: |
| 203 | def __getslice__(self, i, h): pass |
| 204 | def __setslice__(self, i, j, what): pass |
| 205 | def __delslice__(self, i, j): pass |
| 206 | |
| 207 | expected = "in 3.x, __{0}slice__ has been removed; use __{0}item__" |
| 208 | |
| 209 | for obj in (Spam(), Egg()): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 210 | with check_warnings() as w: |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 211 | self.assertWarning(obj[1:2], w, expected.format('get')) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 212 | w.reset() |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 213 | del obj[3:4] |
| 214 | self.assertWarning(None, w, expected.format('del')) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 215 | w.reset() |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 216 | obj[4:5] = "eggs" |
| 217 | self.assertWarning(None, w, expected.format('set')) |
| 218 | |
Benjamin Peterson | f4fcdb6 | 2008-06-08 23:00:00 +0000 | [diff] [blame] | 219 | def test_tuple_parameter_unpacking(self): |
| 220 | expected = "tuple parameter unpacking has been removed in 3.x" |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 221 | with check_warnings() as w: |
Benjamin Peterson | f4fcdb6 | 2008-06-08 23:00:00 +0000 | [diff] [blame] | 222 | exec "def f((a, b)): pass" |
| 223 | self.assertWarning(None, w, expected) |
| 224 | |
Georg Brandl | 80055f6 | 2008-03-25 07:56:27 +0000 | [diff] [blame] | 225 | def test_buffer(self): |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 226 | expected = 'buffer() not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 227 | with check_warnings() as w: |
Georg Brandl | 80055f6 | 2008-03-25 07:56:27 +0000 | [diff] [blame] | 228 | self.assertWarning(buffer('a'), w, expected) |
| 229 | |
Georg Brandl | a9916b5 | 2008-05-17 22:11:54 +0000 | [diff] [blame] | 230 | def test_file_xreadlines(self): |
| 231 | expected = ("f.xreadlines() not supported in 3.x, " |
| 232 | "try 'for line in f' instead") |
| 233 | with file(__file__) as f: |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 234 | with check_warnings() as w: |
Georg Brandl | a9916b5 | 2008-05-17 22:11:54 +0000 | [diff] [blame] | 235 | self.assertWarning(f.xreadlines(), w, expected) |
| 236 | |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 237 | def test_hash_inheritance(self): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 238 | with check_warnings() as w: |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 239 | # With object as the base class |
| 240 | class WarnOnlyCmp(object): |
| 241 | def __cmp__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 242 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 243 | self.assertWarning(None, w, |
| 244 | "Overriding __cmp__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 245 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 246 | class WarnOnlyEq(object): |
| 247 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 248 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 249 | self.assertWarning(None, w, |
| 250 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 251 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 252 | class WarnCmpAndEq(object): |
| 253 | def __cmp__(self, other): pass |
| 254 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 255 | self.assertEqual(len(w.warnings), 2) |
| 256 | self.assertWarning(None, w.warnings[0], |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 257 | "Overriding __cmp__ blocks inheritance of __hash__ in 3.x") |
| 258 | self.assertWarning(None, w, |
| 259 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 260 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 261 | class NoWarningOnlyHash(object): |
| 262 | def __hash__(self): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 263 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 264 | # With an intermediate class in the heirarchy |
| 265 | class DefinesAllThree(object): |
| 266 | def __cmp__(self, other): pass |
| 267 | def __eq__(self, other): pass |
| 268 | def __hash__(self): pass |
| 269 | class WarnOnlyCmp(DefinesAllThree): |
| 270 | def __cmp__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 271 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 272 | self.assertWarning(None, w, |
| 273 | "Overriding __cmp__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 274 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 275 | class WarnOnlyEq(DefinesAllThree): |
| 276 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 277 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 278 | self.assertWarning(None, w, |
| 279 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 280 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 281 | class WarnCmpAndEq(DefinesAllThree): |
| 282 | def __cmp__(self, other): pass |
| 283 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 284 | self.assertEqual(len(w.warnings), 2) |
| 285 | self.assertWarning(None, w.warnings[0], |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 286 | "Overriding __cmp__ blocks inheritance of __hash__ in 3.x") |
| 287 | self.assertWarning(None, w, |
| 288 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 289 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 290 | class NoWarningOnlyHash(DefinesAllThree): |
| 291 | def __hash__(self): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 292 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 293 | |
Alexandre Vassalotti | 0fe7991 | 2009-07-05 04:22:40 +0000 | [diff] [blame] | 294 | def test_operator(self): |
| 295 | from operator import isCallable, sequenceIncludes |
| 296 | |
Alexandre Vassalotti | 16a0247 | 2009-07-05 04:25:46 +0000 | [diff] [blame] | 297 | callable_warn = ("operator.isCallable() is not supported in 3.x. " |
| 298 | "Use hasattr(obj, '__call__').") |
Alexandre Vassalotti | 0fe7991 | 2009-07-05 04:22:40 +0000 | [diff] [blame] | 299 | seq_warn = ("operator.sequenceIncludes() is not supported " |
| 300 | "in 3.x. Use operator.contains().") |
| 301 | with check_warnings() as w: |
| 302 | self.assertWarning(isCallable(self), w, callable_warn) |
| 303 | w.reset() |
| 304 | self.assertWarning(sequenceIncludes(range(3), 2), w, seq_warn) |
| 305 | |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 306 | |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 307 | class TestStdlibRemovals(unittest.TestCase): |
| 308 | |
Brett Cannon | 3c75914 | 2008-05-09 05:25:37 +0000 | [diff] [blame] | 309 | # test.testall not tested as it executes all unit tests as an |
| 310 | # import side-effect. |
Brett Cannon | 4c1f881 | 2008-05-10 02:27:04 +0000 | [diff] [blame] | 311 | all_platforms = ('audiodev', 'imputil', 'mutex', 'user', 'new', 'rexec', |
Brett Cannon | 1e8fba7 | 2008-07-18 19:30:22 +0000 | [diff] [blame] | 312 | 'Bastion', 'compiler', 'dircache', 'mimetools', |
| 313 | 'fpformat', 'ihooks', 'mhlib', 'statvfs', 'htmllib', |
| 314 | 'sgmllib', 'rfc822', 'sunaudio') |
Brett Cannon | 54c77aa | 2008-05-14 21:08:41 +0000 | [diff] [blame] | 315 | inclusive_platforms = {'irix' : ('pure', 'AL', 'al', 'CD', 'cd', 'cddb', |
Brett Cannon | 044616a | 2008-05-15 02:33:55 +0000 | [diff] [blame] | 316 | 'cdplayer', 'CL', 'cl', 'DEVICE', 'GL', |
Brett Cannon | 75ba465 | 2008-05-15 03:23:17 +0000 | [diff] [blame] | 317 | 'gl', 'ERRNO', 'FILE', 'FL', 'flp', 'fl', |
Brett Cannon | d8c41ec | 2008-05-15 03:41:55 +0000 | [diff] [blame] | 318 | 'fm', 'GET', 'GLWS', 'imgfile', 'IN', |
Brett Cannon | cd2de08 | 2008-05-15 03:51:21 +0000 | [diff] [blame] | 319 | 'IOCTL', 'jpeg', 'panel', 'panelparser', |
Brett Cannon | 74a596c | 2008-05-15 04:17:35 +0000 | [diff] [blame] | 320 | 'readcd', 'SV', 'torgb', 'WAIT'), |
Benjamin Peterson | 2368193 | 2008-05-12 21:42:13 +0000 | [diff] [blame] | 321 | 'darwin' : ('autoGIL', 'Carbon', 'OSATerminology', |
Brett Cannon | ea785fb | 2008-05-14 01:09:40 +0000 | [diff] [blame] | 322 | 'icglue', 'Nav', 'MacOS', 'aepack', |
| 323 | 'aetools', 'aetypes', 'applesingle', |
| 324 | 'appletrawmain', 'appletrunner', |
| 325 | 'argvemulator', 'bgenlocations', |
Benjamin Peterson | 2368193 | 2008-05-12 21:42:13 +0000 | [diff] [blame] | 326 | 'EasyDialogs', 'macerrors', 'macostools', |
| 327 | 'findertools', 'FrameWork', 'ic', |
| 328 | 'gensuitemodule', 'icopen', 'macresource', |
| 329 | 'MiniAEFrame', 'pimp', 'PixMapWrapper', |
Brett Cannon | ea785fb | 2008-05-14 01:09:40 +0000 | [diff] [blame] | 330 | 'terminalcommand', 'videoreader', |
| 331 | '_builtinSuites', 'CodeWarrior', |
| 332 | 'Explorer', 'Finder', 'Netscape', |
| 333 | 'StdSuites', 'SystemEvents', 'Terminal', |
| 334 | 'cfmfile', 'bundlebuilder', 'buildtools', |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 335 | 'ColorPicker', 'Audio_mac'), |
Brett Cannon | 2224817 | 2008-05-16 00:10:24 +0000 | [diff] [blame] | 336 | 'sunos5' : ('sunaudiodev', 'SUNAUDIODEV'), |
| 337 | } |
Brett Cannon | ac861b5 | 2008-05-12 03:45:59 +0000 | [diff] [blame] | 338 | optional_modules = ('bsddb185', 'Canvas', 'dl', 'linuxaudiodev', 'imageop', |
Antoine Pitrou | 8015725 | 2010-01-08 19:20:17 +0000 | [diff] [blame] | 339 | 'sv', 'bsddb', 'dbhash') |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 340 | |
Brett Cannon | 9ac3974 | 2008-05-09 22:51:58 +0000 | [diff] [blame] | 341 | def check_removal(self, module_name, optional=False): |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 342 | """Make sure the specified module, when imported, raises a |
| 343 | DeprecationWarning and specifies itself in the message.""" |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 344 | with nested(CleanImport(module_name), warnings.catch_warnings()): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 345 | # XXX: This is not quite enough for extension modules - those |
| 346 | # won't rerun their init code even with CleanImport. |
| 347 | # You can see this easily by running the whole test suite with -3 |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 348 | warnings.filterwarnings("error", ".+ removed", |
| 349 | DeprecationWarning, __name__) |
| 350 | try: |
| 351 | __import__(module_name, level=0) |
| 352 | except DeprecationWarning as exc: |
Ezio Melotti | aa98058 | 2010-01-23 23:04:36 +0000 | [diff] [blame] | 353 | self.assertIn(module_name, exc.args[0], |
| 354 | "%s warning didn't contain module name" |
| 355 | % module_name) |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 356 | except ImportError: |
| 357 | if not optional: |
| 358 | self.fail("Non-optional module {0} raised an " |
| 359 | "ImportError.".format(module_name)) |
| 360 | else: |
| 361 | self.fail("DeprecationWarning not raised for {0}" |
| 362 | .format(module_name)) |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 363 | |
| 364 | def test_platform_independent_removals(self): |
| 365 | # Make sure that the modules that are available on all platforms raise |
| 366 | # the proper DeprecationWarning. |
| 367 | for module_name in self.all_platforms: |
| 368 | self.check_removal(module_name) |
| 369 | |
Brett Cannon | 9ac3974 | 2008-05-09 22:51:58 +0000 | [diff] [blame] | 370 | def test_platform_specific_removals(self): |
| 371 | # Test the removal of platform-specific modules. |
| 372 | for module_name in self.inclusive_platforms.get(sys.platform, []): |
| 373 | self.check_removal(module_name, optional=True) |
| 374 | |
Brett Cannon | 768d44f | 2008-05-10 02:47:54 +0000 | [diff] [blame] | 375 | def test_optional_module_removals(self): |
| 376 | # Test the removal of modules that may or may not be built. |
| 377 | for module_name in self.optional_modules: |
| 378 | self.check_removal(module_name, optional=True) |
| 379 | |
Benjamin Peterson | 0893a0a | 2008-05-09 00:27:01 +0000 | [diff] [blame] | 380 | def test_os_path_walk(self): |
| 381 | msg = "In 3.x, os.path.walk is removed in favor of os.walk." |
| 382 | def dumbo(where, names, args): pass |
| 383 | for path_mod in ("ntpath", "macpath", "os2emxpath", "posixpath"): |
| 384 | mod = __import__(path_mod) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 385 | reset_module_registry(mod) |
| 386 | with check_warnings() as w: |
Benjamin Peterson | 1d31023 | 2008-05-27 01:42:29 +0000 | [diff] [blame] | 387 | mod.walk("crashers", dumbo, None) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 388 | self.assertEquals(str(w.message), msg) |
Benjamin Peterson | 0893a0a | 2008-05-09 00:27:01 +0000 | [diff] [blame] | 389 | |
Benjamin Peterson | 541f7da | 2008-08-18 02:12:23 +0000 | [diff] [blame] | 390 | def test_reduce_move(self): |
| 391 | from operator import add |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 392 | # reduce tests may have already triggered this warning |
| 393 | reset_module_registry(unittest) |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 394 | with warnings.catch_warnings(): |
Benjamin Peterson | 541f7da | 2008-08-18 02:12:23 +0000 | [diff] [blame] | 395 | warnings.filterwarnings("error", "reduce") |
| 396 | self.assertRaises(DeprecationWarning, reduce, add, range(10)) |
| 397 | |
Brett Cannon | abb34fe | 2008-05-29 05:08:50 +0000 | [diff] [blame] | 398 | def test_mutablestring_removal(self): |
| 399 | # UserString.MutableString has been removed in 3.0. |
| 400 | import UserString |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 401 | # UserString tests may have already triggered this warning |
| 402 | reset_module_registry(UserString) |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 403 | with warnings.catch_warnings(): |
Brett Cannon | abb34fe | 2008-05-29 05:08:50 +0000 | [diff] [blame] | 404 | warnings.filterwarnings("error", ".*MutableString", |
| 405 | DeprecationWarning) |
| 406 | self.assertRaises(DeprecationWarning, UserString.MutableString) |
| 407 | |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 408 | |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 409 | def test_main(): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 410 | with check_warnings(): |
Benjamin Peterson | 1d31023 | 2008-05-27 01:42:29 +0000 | [diff] [blame] | 411 | warnings.simplefilter("always") |
| 412 | run_unittest(TestPy3KWarnings, |
| 413 | TestStdlibRemovals) |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 414 | |
| 415 | if __name__ == '__main__': |
| 416 | test_main() |