Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 1 | import unittest |
Brett Cannon | 977eb02 | 2008-03-19 17:37:43 +0000 | [diff] [blame] | 2 | import sys |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 3 | from test.test_support import (check_warnings, CleanImport, |
| 4 | TestSkipped, run_unittest) |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 5 | import warnings |
| 6 | |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 7 | from contextlib import nested |
| 8 | |
Brett Cannon | 977eb02 | 2008-03-19 17:37:43 +0000 | [diff] [blame] | 9 | if not sys.py3kwarning: |
| 10 | raise TestSkipped('%s must be run with the -3 flag' % __name__) |
| 11 | |
Ezio Melotti | f9c2f4f | 2010-08-02 21:48:39 +0000 | [diff] [blame] | 12 | try: |
| 13 | from test.test_support import __warningregistry__ as _registry |
| 14 | except ImportError: |
| 15 | def check_deprecated_module(module_name): |
| 16 | return False |
| 17 | else: |
| 18 | past_warnings = _registry.keys() |
| 19 | del _registry |
| 20 | def check_deprecated_module(module_name): |
| 21 | """Lookup the past warnings for module already loaded using |
| 22 | test_support.import_module(..., deprecated=True) |
| 23 | """ |
| 24 | return any(module_name in msg and ' removed' in msg |
| 25 | and issubclass(cls, DeprecationWarning) |
| 26 | and (' module' in msg or ' package' in msg) |
| 27 | for (msg, cls, line) in past_warnings) |
| 28 | |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 29 | def reset_module_registry(module): |
| 30 | try: |
| 31 | registry = module.__warningregistry__ |
| 32 | except AttributeError: |
| 33 | pass |
| 34 | else: |
| 35 | registry.clear() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 36 | |
| 37 | class TestPy3KWarnings(unittest.TestCase): |
| 38 | |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 39 | def assertWarning(self, _, warning, expected_message): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 40 | self.assertEqual(str(warning.message), expected_message) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 41 | |
Benjamin Peterson | f921469 | 2009-07-02 17:19:22 +0000 | [diff] [blame] | 42 | def assertNoWarning(self, _, recorder): |
| 43 | self.assertEqual(len(recorder.warnings), 0) |
| 44 | |
Benjamin Peterson | 2fe3ef8 | 2008-06-08 02:05:33 +0000 | [diff] [blame] | 45 | def test_backquote(self): |
| 46 | expected = 'backquote not supported in 3.x; use repr()' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 47 | with check_warnings() as w: |
Benjamin Peterson | 2fe3ef8 | 2008-06-08 02:05:33 +0000 | [diff] [blame] | 48 | exec "`2`" in {} |
| 49 | self.assertWarning(None, w, expected) |
| 50 | |
Benjamin Peterson | 440847c | 2009-11-19 23:01:36 +0000 | [diff] [blame] | 51 | def test_paren_arg_names(self): |
| 52 | expected = 'parenthesized argument names are invalid in 3.x' |
| 53 | def check(s): |
| 54 | exec s in {} |
| 55 | self.assertWarning(None, w, expected) |
| 56 | with check_warnings() as w: |
| 57 | check("def f((x)): pass") |
| 58 | check("def f((((x))), (y)): pass") |
| 59 | check("def f((x), (((y))), m=32): pass") |
| 60 | # Something like def f((a, (b))): pass will raise the tuple |
| 61 | # unpacking warning. |
| 62 | |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 63 | def test_bool_assign(self): |
| 64 | # So we don't screw up our globals |
| 65 | def safe_exec(expr): |
| 66 | def f(**kwargs): pass |
| 67 | exec expr in {'f' : f} |
| 68 | |
| 69 | expected = "assignment to True or False is forbidden in 3.x" |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 70 | with check_warnings() as w: |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 71 | safe_exec("True = False") |
| 72 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 73 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 74 | safe_exec("False = True") |
| 75 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 76 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 77 | try: |
| 78 | safe_exec("obj.False = True") |
| 79 | except NameError: pass |
| 80 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 81 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 82 | try: |
| 83 | safe_exec("obj.True = False") |
| 84 | except NameError: pass |
| 85 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 86 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 87 | safe_exec("def False(): pass") |
| 88 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 89 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 90 | safe_exec("def True(): pass") |
| 91 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 92 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 93 | safe_exec("class False: pass") |
| 94 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 95 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 96 | safe_exec("class True: pass") |
| 97 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 98 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 99 | safe_exec("def f(True=43): pass") |
| 100 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 101 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 102 | safe_exec("def f(False=None): pass") |
| 103 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 104 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 105 | safe_exec("f(False=True)") |
| 106 | self.assertWarning(None, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 107 | w.reset() |
Benjamin Peterson | d5efd20 | 2008-06-08 22:52:37 +0000 | [diff] [blame] | 108 | safe_exec("f(True=1)") |
| 109 | self.assertWarning(None, w, expected) |
| 110 | |
| 111 | |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 112 | def test_type_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 113 | expected = 'type inequality comparisons not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 114 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 115 | self.assertWarning(int < str, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 116 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 117 | self.assertWarning(type < object, w, expected) |
| 118 | |
| 119 | def test_object_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 120 | expected = 'comparing unequal types not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 121 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 122 | self.assertWarning(str < [], w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 123 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 124 | self.assertWarning(object() < (1, 2), w, expected) |
| 125 | |
| 126 | def test_dict_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 127 | expected = 'dict inequality comparisons not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 128 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 129 | self.assertWarning({} < {2:3}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 130 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 131 | self.assertWarning({} <= {}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 132 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 133 | self.assertWarning({} > {2:3}, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 134 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 135 | self.assertWarning({2:3} >= {}, w, expected) |
| 136 | |
| 137 | def test_cell_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 138 | expected = 'cell comparisons not supported in 3.x' |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 139 | def f(x): |
| 140 | def g(): |
| 141 | return x |
| 142 | return g |
| 143 | cell0, = f(0).func_closure |
| 144 | cell1, = f(1).func_closure |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 145 | with check_warnings() as w: |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 146 | self.assertWarning(cell0 == cell1, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 147 | w.reset() |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 148 | self.assertWarning(cell0 < cell1, w, expected) |
| 149 | |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 150 | def test_code_inequality_comparisons(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 151 | expected = 'code inequality comparisons not supported in 3.x' |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 152 | def f(x): |
| 153 | pass |
| 154 | def g(x): |
| 155 | pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 156 | with check_warnings() as w: |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 157 | self.assertWarning(f.func_code < g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 158 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 159 | self.assertWarning(f.func_code <= g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 160 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 161 | self.assertWarning(f.func_code >= g.func_code, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 162 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 163 | self.assertWarning(f.func_code > g.func_code, w, expected) |
| 164 | |
| 165 | def test_builtin_function_or_method_comparisons(self): |
| 166 | expected = ('builtin_function_or_method ' |
Benjamin Peterson | f921469 | 2009-07-02 17:19:22 +0000 | [diff] [blame] | 167 | 'order comparisons not supported in 3.x') |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 168 | func = eval |
| 169 | meth = {}.get |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 170 | with check_warnings() as w: |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 171 | self.assertWarning(func < meth, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 172 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 173 | self.assertWarning(func > meth, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 174 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 175 | self.assertWarning(meth <= func, w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 176 | w.reset() |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 177 | self.assertWarning(meth >= func, w, expected) |
Benjamin Peterson | f921469 | 2009-07-02 17:19:22 +0000 | [diff] [blame] | 178 | w.reset() |
| 179 | self.assertNoWarning(meth == func, w) |
| 180 | self.assertNoWarning(meth != func, w) |
| 181 | lam = lambda x: x |
| 182 | self.assertNoWarning(lam == func, w) |
| 183 | self.assertNoWarning(lam != func, w) |
Steven Bethard | 6a644f9 | 2008-03-18 22:08:20 +0000 | [diff] [blame] | 184 | |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 185 | def test_sort_cmp_arg(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 186 | expected = "the cmp argument is not supported in 3.x" |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 187 | lst = range(5) |
| 188 | cmp = lambda x,y: -1 |
| 189 | |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 190 | with check_warnings() as w: |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 191 | self.assertWarning(lst.sort(cmp=cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 192 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 193 | self.assertWarning(sorted(lst, cmp=cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 194 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 195 | self.assertWarning(lst.sort(cmp), w, expected) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 196 | w.reset() |
Raymond Hettinger | 0538786 | 2008-03-19 17:45:19 +0000 | [diff] [blame] | 197 | self.assertWarning(sorted(lst, cmp), w, expected) |
| 198 | |
Georg Brandl | 5a44424 | 2008-03-21 20:11:46 +0000 | [diff] [blame] | 199 | def test_sys_exc_clear(self): |
Georg Brandl | d5b635f | 2008-03-25 08:29:14 +0000 | [diff] [blame] | 200 | expected = 'sys.exc_clear() not supported in 3.x; use except clauses' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 201 | with check_warnings() as w: |
Georg Brandl | 5a44424 | 2008-03-21 20:11:46 +0000 | [diff] [blame] | 202 | self.assertWarning(sys.exc_clear(), w, expected) |
| 203 | |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 204 | def test_methods_members(self): |
| 205 | expected = '__members__ and __methods__ not supported in 3.x' |
| 206 | class C: |
| 207 | __methods__ = ['a'] |
| 208 | __members__ = ['b'] |
| 209 | c = C() |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 210 | with check_warnings() as w: |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 211 | self.assertWarning(dir(c), w, expected) |
| 212 | |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 213 | def test_softspace(self): |
| 214 | expected = 'file.softspace not supported in 3.x' |
| 215 | with file(__file__) as f: |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 216 | with check_warnings() as w: |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 217 | self.assertWarning(f.softspace, w, expected) |
| 218 | def set(): |
| 219 | f.softspace = 0 |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 220 | with check_warnings() as w: |
Georg Brandl | 65bb42d | 2008-03-21 20:38:24 +0000 | [diff] [blame] | 221 | self.assertWarning(set(), w, expected) |
| 222 | |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 223 | def test_slice_methods(self): |
| 224 | class Spam(object): |
| 225 | def __getslice__(self, i, j): pass |
| 226 | def __setslice__(self, i, j, what): pass |
| 227 | def __delslice__(self, i, j): pass |
| 228 | class Egg: |
| 229 | def __getslice__(self, i, h): pass |
| 230 | def __setslice__(self, i, j, what): pass |
| 231 | def __delslice__(self, i, j): pass |
| 232 | |
| 233 | expected = "in 3.x, __{0}slice__ has been removed; use __{0}item__" |
| 234 | |
| 235 | for obj in (Spam(), Egg()): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 236 | with check_warnings() as w: |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 237 | self.assertWarning(obj[1:2], w, expected.format('get')) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 238 | w.reset() |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 239 | del obj[3:4] |
| 240 | self.assertWarning(None, w, expected.format('del')) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 241 | w.reset() |
Benjamin Peterson | 712ee92 | 2008-08-24 18:10:20 +0000 | [diff] [blame] | 242 | obj[4:5] = "eggs" |
| 243 | self.assertWarning(None, w, expected.format('set')) |
| 244 | |
Benjamin Peterson | f4fcdb6 | 2008-06-08 23:00:00 +0000 | [diff] [blame] | 245 | def test_tuple_parameter_unpacking(self): |
| 246 | expected = "tuple parameter unpacking has been removed in 3.x" |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 247 | with check_warnings() as w: |
Benjamin Peterson | f4fcdb6 | 2008-06-08 23:00:00 +0000 | [diff] [blame] | 248 | exec "def f((a, b)): pass" |
| 249 | self.assertWarning(None, w, expected) |
| 250 | |
Georg Brandl | 80055f6 | 2008-03-25 07:56:27 +0000 | [diff] [blame] | 251 | def test_buffer(self): |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 252 | expected = 'buffer() not supported in 3.x' |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 253 | with check_warnings() as w: |
Georg Brandl | 80055f6 | 2008-03-25 07:56:27 +0000 | [diff] [blame] | 254 | self.assertWarning(buffer('a'), w, expected) |
| 255 | |
Georg Brandl | a9916b5 | 2008-05-17 22:11:54 +0000 | [diff] [blame] | 256 | def test_file_xreadlines(self): |
| 257 | expected = ("f.xreadlines() not supported in 3.x, " |
| 258 | "try 'for line in f' instead") |
| 259 | with file(__file__) as f: |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 260 | with check_warnings() as w: |
Georg Brandl | a9916b5 | 2008-05-17 22:11:54 +0000 | [diff] [blame] | 261 | self.assertWarning(f.xreadlines(), w, expected) |
| 262 | |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 263 | def test_hash_inheritance(self): |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 264 | with check_warnings() as w: |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 265 | # With object as the base class |
| 266 | class WarnOnlyCmp(object): |
| 267 | def __cmp__(self, other): pass |
Mark Dickinson | 3f91811 | 2010-06-05 13:24:04 +0000 | [diff] [blame] | 268 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 269 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 270 | class WarnOnlyEq(object): |
| 271 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 272 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 273 | self.assertWarning(None, w, |
| 274 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 275 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 276 | class WarnCmpAndEq(object): |
| 277 | def __cmp__(self, other): pass |
| 278 | def __eq__(self, other): pass |
Mark Dickinson | 3f91811 | 2010-06-05 13:24:04 +0000 | [diff] [blame] | 279 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 280 | self.assertWarning(None, w, |
| 281 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 282 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 283 | class NoWarningOnlyHash(object): |
| 284 | def __hash__(self): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 285 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 286 | # With an intermediate class in the heirarchy |
| 287 | class DefinesAllThree(object): |
| 288 | def __cmp__(self, other): pass |
| 289 | def __eq__(self, other): pass |
| 290 | def __hash__(self): pass |
| 291 | class WarnOnlyCmp(DefinesAllThree): |
| 292 | def __cmp__(self, other): pass |
Mark Dickinson | 3f91811 | 2010-06-05 13:24:04 +0000 | [diff] [blame] | 293 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 294 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 295 | class WarnOnlyEq(DefinesAllThree): |
| 296 | def __eq__(self, other): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 297 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 298 | self.assertWarning(None, w, |
| 299 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 300 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 301 | class WarnCmpAndEq(DefinesAllThree): |
| 302 | def __cmp__(self, other): pass |
| 303 | def __eq__(self, other): pass |
Mark Dickinson | 3f91811 | 2010-06-05 13:24:04 +0000 | [diff] [blame] | 304 | self.assertEqual(len(w.warnings), 1) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 305 | self.assertWarning(None, w, |
| 306 | "Overriding __eq__ blocks inheritance of __hash__ in 3.x") |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 307 | w.reset() |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 308 | class NoWarningOnlyHash(DefinesAllThree): |
| 309 | def __hash__(self): pass |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 310 | self.assertEqual(len(w.warnings), 0) |
Nick Coghlan | 48361f5 | 2008-08-11 15:45:58 +0000 | [diff] [blame] | 311 | |
Georg Brandl | 07e5681 | 2008-03-21 20:21:46 +0000 | [diff] [blame] | 312 | |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 313 | class TestStdlibRemovals(unittest.TestCase): |
| 314 | |
Brett Cannon | 3c75914 | 2008-05-09 05:25:37 +0000 | [diff] [blame] | 315 | # test.testall not tested as it executes all unit tests as an |
| 316 | # import side-effect. |
Brett Cannon | 4c1f881 | 2008-05-10 02:27:04 +0000 | [diff] [blame] | 317 | all_platforms = ('audiodev', 'imputil', 'mutex', 'user', 'new', 'rexec', |
Brett Cannon | 1e8fba7 | 2008-07-18 19:30:22 +0000 | [diff] [blame] | 318 | 'Bastion', 'compiler', 'dircache', 'mimetools', |
| 319 | 'fpformat', 'ihooks', 'mhlib', 'statvfs', 'htmllib', |
| 320 | 'sgmllib', 'rfc822', 'sunaudio') |
Brett Cannon | 54c77aa | 2008-05-14 21:08:41 +0000 | [diff] [blame] | 321 | inclusive_platforms = {'irix' : ('pure', 'AL', 'al', 'CD', 'cd', 'cddb', |
Brett Cannon | 044616a | 2008-05-15 02:33:55 +0000 | [diff] [blame] | 322 | 'cdplayer', 'CL', 'cl', 'DEVICE', 'GL', |
Brett Cannon | 75ba465 | 2008-05-15 03:23:17 +0000 | [diff] [blame] | 323 | 'gl', 'ERRNO', 'FILE', 'FL', 'flp', 'fl', |
Brett Cannon | d8c41ec | 2008-05-15 03:41:55 +0000 | [diff] [blame] | 324 | 'fm', 'GET', 'GLWS', 'imgfile', 'IN', |
Brett Cannon | cd2de08 | 2008-05-15 03:51:21 +0000 | [diff] [blame] | 325 | 'IOCTL', 'jpeg', 'panel', 'panelparser', |
Brett Cannon | 74a596c | 2008-05-15 04:17:35 +0000 | [diff] [blame] | 326 | 'readcd', 'SV', 'torgb', 'WAIT'), |
Benjamin Peterson | 2368193 | 2008-05-12 21:42:13 +0000 | [diff] [blame] | 327 | 'darwin' : ('autoGIL', 'Carbon', 'OSATerminology', |
Brett Cannon | ea785fb | 2008-05-14 01:09:40 +0000 | [diff] [blame] | 328 | 'icglue', 'Nav', 'MacOS', 'aepack', |
| 329 | 'aetools', 'aetypes', 'applesingle', |
| 330 | 'appletrawmain', 'appletrunner', |
| 331 | 'argvemulator', 'bgenlocations', |
Benjamin Peterson | 2368193 | 2008-05-12 21:42:13 +0000 | [diff] [blame] | 332 | 'EasyDialogs', 'macerrors', 'macostools', |
| 333 | 'findertools', 'FrameWork', 'ic', |
| 334 | 'gensuitemodule', 'icopen', 'macresource', |
| 335 | 'MiniAEFrame', 'pimp', 'PixMapWrapper', |
Brett Cannon | ea785fb | 2008-05-14 01:09:40 +0000 | [diff] [blame] | 336 | 'terminalcommand', 'videoreader', |
| 337 | '_builtinSuites', 'CodeWarrior', |
| 338 | 'Explorer', 'Finder', 'Netscape', |
| 339 | 'StdSuites', 'SystemEvents', 'Terminal', |
| 340 | 'cfmfile', 'bundlebuilder', 'buildtools', |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 341 | 'ColorPicker', 'Audio_mac'), |
Brett Cannon | 2224817 | 2008-05-16 00:10:24 +0000 | [diff] [blame] | 342 | 'sunos5' : ('sunaudiodev', 'SUNAUDIODEV'), |
| 343 | } |
Brett Cannon | ac861b5 | 2008-05-12 03:45:59 +0000 | [diff] [blame] | 344 | optional_modules = ('bsddb185', 'Canvas', 'dl', 'linuxaudiodev', 'imageop', |
Antoine Pitrou | 0b07457 | 2010-01-08 19:21:34 +0000 | [diff] [blame] | 345 | 'sv', 'bsddb', 'dbhash') |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 346 | |
Brett Cannon | 9ac3974 | 2008-05-09 22:51:58 +0000 | [diff] [blame] | 347 | def check_removal(self, module_name, optional=False): |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 348 | """Make sure the specified module, when imported, raises a |
| 349 | DeprecationWarning and specifies itself in the message.""" |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 350 | with nested(CleanImport(module_name), warnings.catch_warnings()): |
Ezio Melotti | f9c2f4f | 2010-08-02 21:48:39 +0000 | [diff] [blame] | 351 | warnings.filterwarnings("error", ".+ (module|package) .+ removed", |
| 352 | DeprecationWarning, __name__) |
| 353 | warnings.filterwarnings("error", ".+ removed .+ (module|package)", |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 354 | DeprecationWarning, __name__) |
| 355 | try: |
| 356 | __import__(module_name, level=0) |
| 357 | except DeprecationWarning as exc: |
| 358 | self.assert_(module_name in exc.args[0], |
| 359 | "%s warning didn't contain module name" |
| 360 | % module_name) |
| 361 | except ImportError: |
| 362 | if not optional: |
| 363 | self.fail("Non-optional module {0} raised an " |
| 364 | "ImportError.".format(module_name)) |
| 365 | else: |
Ezio Melotti | f9c2f4f | 2010-08-02 21:48:39 +0000 | [diff] [blame] | 366 | # For extension modules, check the __warningregistry__. |
| 367 | # They won't rerun their init code even with CleanImport. |
| 368 | if not check_deprecated_module(module_name): |
| 369 | self.fail("DeprecationWarning not raised for {0}" |
Benjamin Peterson | a6864e0 | 2008-07-14 17:42:17 +0000 | [diff] [blame] | 370 | .format(module_name)) |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 371 | |
| 372 | def test_platform_independent_removals(self): |
| 373 | # Make sure that the modules that are available on all platforms raise |
| 374 | # the proper DeprecationWarning. |
| 375 | for module_name in self.all_platforms: |
| 376 | self.check_removal(module_name) |
| 377 | |
Brett Cannon | 9ac3974 | 2008-05-09 22:51:58 +0000 | [diff] [blame] | 378 | def test_platform_specific_removals(self): |
| 379 | # Test the removal of platform-specific modules. |
| 380 | for module_name in self.inclusive_platforms.get(sys.platform, []): |
| 381 | self.check_removal(module_name, optional=True) |
| 382 | |
Brett Cannon | 768d44f | 2008-05-10 02:47:54 +0000 | [diff] [blame] | 383 | def test_optional_module_removals(self): |
| 384 | # Test the removal of modules that may or may not be built. |
| 385 | for module_name in self.optional_modules: |
| 386 | self.check_removal(module_name, optional=True) |
| 387 | |
Benjamin Peterson | 0893a0a | 2008-05-09 00:27:01 +0000 | [diff] [blame] | 388 | def test_os_path_walk(self): |
| 389 | msg = "In 3.x, os.path.walk is removed in favor of os.walk." |
| 390 | def dumbo(where, names, args): pass |
| 391 | for path_mod in ("ntpath", "macpath", "os2emxpath", "posixpath"): |
| 392 | mod = __import__(path_mod) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 393 | reset_module_registry(mod) |
| 394 | with check_warnings() as w: |
Benjamin Peterson | 1d31023 | 2008-05-27 01:42:29 +0000 | [diff] [blame] | 395 | mod.walk("crashers", dumbo, None) |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 396 | self.assertEquals(str(w.message), msg) |
Benjamin Peterson | 0893a0a | 2008-05-09 00:27:01 +0000 | [diff] [blame] | 397 | |
Benjamin Peterson | 3aa84a7 | 2008-05-26 19:41:53 +0000 | [diff] [blame] | 398 | def test_commands_members(self): |
| 399 | import commands |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 400 | # commands module tests may have already triggered this warning |
| 401 | reset_module_registry(commands) |
Benjamin Peterson | 3aa84a7 | 2008-05-26 19:41:53 +0000 | [diff] [blame] | 402 | members = {"mk2arg" : 2, "mkarg" : 1, "getstatus" : 1} |
| 403 | for name, arg_count in members.items(): |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 404 | with warnings.catch_warnings(): |
Benjamin Peterson | 3aa84a7 | 2008-05-26 19:41:53 +0000 | [diff] [blame] | 405 | warnings.filterwarnings("error") |
| 406 | func = getattr(commands, name) |
| 407 | self.assertRaises(DeprecationWarning, func, *([None]*arg_count)) |
| 408 | |
Benjamin Peterson | 541f7da | 2008-08-18 02:12:23 +0000 | [diff] [blame] | 409 | def test_reduce_move(self): |
| 410 | from operator import add |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 411 | # reduce tests may have already triggered this warning |
| 412 | reset_module_registry(unittest) |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 413 | with warnings.catch_warnings(): |
Benjamin Peterson | 541f7da | 2008-08-18 02:12:23 +0000 | [diff] [blame] | 414 | warnings.filterwarnings("error", "reduce") |
| 415 | self.assertRaises(DeprecationWarning, reduce, add, range(10)) |
| 416 | |
Brett Cannon | abb34fe | 2008-05-29 05:08:50 +0000 | [diff] [blame] | 417 | def test_mutablestring_removal(self): |
| 418 | # UserString.MutableString has been removed in 3.0. |
| 419 | import UserString |
Nick Coghlan | d2e0938 | 2008-09-11 12:11:06 +0000 | [diff] [blame] | 420 | # UserString tests may have already triggered this warning |
| 421 | reset_module_registry(UserString) |
Brett Cannon | 672237d | 2008-09-09 00:49:16 +0000 | [diff] [blame] | 422 | with warnings.catch_warnings(): |
Brett Cannon | abb34fe | 2008-05-29 05:08:50 +0000 | [diff] [blame] | 423 | warnings.filterwarnings("error", ".*MutableString", |
| 424 | DeprecationWarning) |
| 425 | self.assertRaises(DeprecationWarning, UserString.MutableString) |
| 426 | |
Brett Cannon | e5d2cba | 2008-05-06 23:23:34 +0000 | [diff] [blame] | 427 | |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 428 | def test_main(): |
Ezio Melotti | f9c2f4f | 2010-08-02 21:48:39 +0000 | [diff] [blame] | 429 | run_unittest(TestPy3KWarnings, |
| 430 | TestStdlibRemovals) |
Steven Bethard | ae42f33 | 2008-03-18 17:26:10 +0000 | [diff] [blame] | 431 | |
| 432 | if __name__ == '__main__': |
| 433 | test_main() |