Issue #19921: When Path.mkdir() is called with parents=True, any missing parent is created with the default permissions, ignoring the mode argument (mimicking the POSIX "mkdir -p" command).
Patch by Serhiy.
diff --git a/Lib/pathlib.py b/Lib/pathlib.py
index 9b4fde1..18facd9 100644
--- a/Lib/pathlib.py
+++ b/Lib/pathlib.py
@@ -1101,7 +1101,7 @@
except OSError as e:
if e.errno != ENOENT:
raise
- self.parent.mkdir(mode, True)
+ self.parent.mkdir(parents=True)
self._accessor.mkdir(self, mode)
def chmod(self, mode):
diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py
index 0ad77e0..bdcba9f 100755
--- a/Lib/test/test_pathlib.py
+++ b/Lib/test/test_pathlib.py
@@ -1478,7 +1478,6 @@
with self.assertRaises(OSError) as cm:
p.mkdir()
self.assertEqual(cm.exception.errno, errno.EEXIST)
- # XXX test `mode` arg
def test_mkdir_parents(self):
# Creating a chain of directories
@@ -1493,7 +1492,17 @@
with self.assertRaises(OSError) as cm:
p.mkdir(parents=True)
self.assertEqual(cm.exception.errno, errno.EEXIST)
- # XXX test `mode` arg
+ # test `mode` arg
+ mode = stat.S_IMODE(p.stat().st_mode) # default mode
+ p = self.cls(BASE, 'newdirD', 'newdirE')
+ p.mkdir(0o555, parents=True)
+ self.assertTrue(p.exists())
+ self.assertTrue(p.is_dir())
+ if os.name != 'nt':
+ # the directory's permissions follow the mode argument
+ self.assertEqual(stat.S_IMODE(p.stat().st_mode), 0o555 & mode)
+ # the parent's permissions follow the default process settings
+ self.assertEqual(stat.S_IMODE(p.parent.stat().st_mode), mode)
@with_symlinks
def test_symlink_to(self):