commit 0247e80f3c529900689425676342cb70ea31a13d
author Eddie Elizondo <eelizondo@fb.com> Sat Sep 14 09:38:17 2019 -0400
committer Dino Viehland <dinoviehland@gmail.com> Sat Sep 14 14:38:17 2019 +0100
tree ffc687b49ea5d6fef86a58b577fb6198229322e5
parent 279f44678c8b84a183f9eeb85e0b086228154497

Fix leaks in Python-ast.c (#16127)

Parser/asdl_c.py

diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
index 6b31ffd8..0b72f9e 100755
--- a/Parser/asdl_c.py
+++ b/Parser/asdl_c.py
@@ -638,9 +638,13 @@
 ast_dealloc(AST_object *self)
 {
     /* bpo-31095: UnTrack is needed before calling any callbacks */
+    PyTypeObject *tp = Py_TYPE(self);
     PyObject_GC_UnTrack(self);
     Py_CLEAR(self->dict);
-    Py_TYPE(self)->tp_free(self);
+    freefunc free_func = PyType_GetSlot(tp, Py_tp_free);
+    assert(free_func != NULL);
+    free_func(self);
+    Py_DECREF(tp);
 }
 
 static int

Python/Python-ast.c

diff --git a/Python/Python-ast.c b/Python/Python-ast.c
index 5190a90..7a38e98 100644
--- a/Python/Python-ast.c
+++ b/Python/Python-ast.c
@@ -1130,9 +1130,13 @@
 ast_dealloc(AST_object *self)
 {
     /* bpo-31095: UnTrack is needed before calling any callbacks */
+    PyTypeObject *tp = Py_TYPE(self);
     PyObject_GC_UnTrack(self);
     Py_CLEAR(self->dict);
-    Py_TYPE(self)->tp_free(self);
+    freefunc free_func = PyType_GetSlot(tp, Py_tp_free);
+    assert(free_func != NULL);
+    free_func(self);
+    Py_DECREF(tp);
 }
 
 static int