otherset is known to be non-NULL based on checks before and DECREF after.
DECREF otherset rather than XDECREF in error conditions too.
Reported by Klockwork #154.
diff --git a/Objects/setobject.c b/Objects/setobject.c
index f10fdd7..3ddb675 100644
--- a/Objects/setobject.c
+++ b/Objects/setobject.c
@@ -1380,12 +1380,12 @@
while (set_next(otherset, &pos, &entry)) {
int rv = set_discard_entry(so, entry);
if (rv == -1) {
- Py_XDECREF(otherset);
+ Py_DECREF(otherset);
return NULL;
}
if (rv == DISCARD_NOTFOUND) {
if (set_add_entry(so, entry) == -1) {
- Py_XDECREF(otherset);
+ Py_DECREF(otherset);
return NULL;
}
}