commit 07019bcaab87114bc2312f2b916f929c99f3c48b
author Alexander Belopolsky <alexander.belopolsky@gmail.com> Tue Apr 05 22:12:22 2011 -0400
committer Alexander Belopolsky <alexander.belopolsky@gmail.com> Tue Apr 05 22:12:22 2011 -0400
tree 07b6c76b3bee35c1e26801d308563050b2819f8c
parent 5f511826c2972c0e4f5de68dba285f7472a3b5bd

Issue #11576: Fixed timedelta subtraction glitch on big timedelta values

Modules/datetimemodule.c

diff --git a/Modules/datetimemodule.c b/Modules/datetimemodule.c
index f907093..f733fa1 100644
--- a/Modules/datetimemodule.c
+++ b/Modules/datetimemodule.c
@@ -1737,13 +1737,14 @@
 
     if (PyDelta_Check(left) && PyDelta_Check(right)) {
         /* delta - delta */
-        PyObject *minus_right = PyNumber_Negative(right);
-        if (minus_right) {
-            result = delta_add(left, minus_right);
-            Py_DECREF(minus_right);
-        }
-        else
-            result = NULL;
+        /* The C-level additions can't overflow because of the
+         * invariant bounds.
+         */
+        int days = GET_TD_DAYS(left) - GET_TD_DAYS(right);
+        int seconds = GET_TD_SECONDS(left) - GET_TD_SECONDS(right);
+        int microseconds = GET_TD_MICROSECONDS(left) -
+                           GET_TD_MICROSECONDS(right);
+        result = new_delta(days, seconds, microseconds, 1);
     }
 
     if (result == Py_NotImplemented)