commit 0e73ea26a55abc0ce2ee1153e5509bcaef4736cf
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Thu Feb 21 00:05:22 2019 -0800
committer GitHub <noreply@github.com> Thu Feb 21 00:05:22 2019 -0800
tree 169770ee6450434483d704cd7574f8c2e780cba6
parent 92ac01b104b80f9251fcb17ab4cc1845c1f91ac2

bpo-33989: Ensure that ms.key_compare is always initialized in list_sort_impl(). (GH-8710)

(cherry picked from commit ebc793d6acb9650b9f497808e059805892031d74)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Objects/listobject.c

diff --git a/Objects/listobject.c b/Objects/listobject.c
index de73b8b..7dc68a7 100644
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -2279,6 +2279,9 @@
             else if ((ms.key_richcompare = key_type->tp_richcompare) != NULL) {
                 ms.key_compare = unsafe_object_compare;
             }
+            else {
+                ms.key_compare = safe_object_compare;
+            }
         }
         else {
             ms.key_compare = safe_object_compare;