tree 1cd9bf3bf4fd632719d119bfd3f4f18220d3ff1c
parent 557802dc17498557e481f2ad3d4a83ece469e489
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> 1565819263 -0700
committer GitHub <noreply@github.com> 1565819263 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJdVIF/CRBK7hj4Ov3rIwAAdHIIAHTs2ex9nCceP37NX6dRN0H4
 ZDZy4+6Q+h6SpSrEUBT3LUr3M3Xp6f6iKJbsUv04IXDGhCkVo3PGYg28k1H81G69
 cgZlKQiMVRsLI5Qn/PLAGDWyoIxbuiRrVtwv2W5V2RnxHX58Y8mTeyDIbfI019C0
 JZs5pNBXfBTeNvcwGVDJPp2kB/ZJSZVCHh2budHccjYNID+onMgLjkqLedIUcEcO
 q11rMlyRcXz8c6iaDvqJaGZ5GdkH80kOT+6+yIkiZ70W2g/0WqULQoxFNYr2vz4K
 mVoQXSOw9IxhGmVUh0hYliwmpFcPpuJckEQjE+vMJTDZHj4XoQZbpeA1dMrSJGc=
 =00J0
 -----END PGP SIGNATURE-----
 

bpo-37811: FreeBSD, OSX: fix poll(2) usage in sockets module (GH-15202)


FreeBSD implementation of poll(2) restricts the timeout argument to be
either zero, or positive, or equal to INFTIM (-1).

Unless otherwise overridden, socket timeout defaults to -1. This value
is then converted to milliseconds (-1000) and used as argument to the
poll syscall. poll returns EINVAL (22), and the connection fails.

This bug was discovered during the EINTR handling testing, and the
reproduction code can be found in
https://bugs.python.org/issue23618 (see connect_eintr.py,
attached). On GNU/Linux, the example runs as expected.

This change is trivial:
If the supplied timeout value is negative, truncate it to -1.
(cherry picked from commit 28146206578ebe1b84b48e6f255738a227058c04)

Co-authored-by: Artem Khramov <akhramov@pm.me>