Issue #21445: Pass exception messages correctly to assertTrue in
the FileCompareTestCase.test_matching test.
Patch by Steven Barker.
diff --git a/Lib/test/test_filecmp.py b/Lib/test/test_filecmp.py
index 429e3ff..b5b24a2 100644
--- a/Lib/test/test_filecmp.py
+++ b/Lib/test/test_filecmp.py
@@ -27,13 +27,13 @@
os.unlink(self.name_diff)
def test_matching(self):
- self.assertTrue(filecmp.cmp(self.name, self.name_same),
- "Comparing file to itself fails")
- self.assertTrue(filecmp.cmp(self.name, self.name_same, shallow=False),
+ self.assertTrue(filecmp.cmp(self.name, self.name),
"Comparing file to itself fails")
self.assertTrue(filecmp.cmp(self.name, self.name, shallow=False),
+ "Comparing file to itself fails")
+ self.assertTrue(filecmp.cmp(self.name, self.name_same),
"Comparing file to identical file fails")
- self.assertTrue(filecmp.cmp(self.name, self.name),
+ self.assertTrue(filecmp.cmp(self.name, self.name_same, shallow=False),
"Comparing file to identical file fails")
def test_different(self):
diff --git a/Misc/ACKS b/Misc/ACKS
index 2c58324..b16dd70 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -78,6 +78,7 @@
Daniel Barclay
Nicolas Bareil
Chris Barker
+Steven Barker
Anton Barkovsky
Nick Barnes
Quentin Barnes