_winconsoleio: Fix memory leak (#2485)
Fix memory leak when _winconsoleio tries to open a non-console file:
free the name buffer.
diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c
index 346c386..5cf3f07 100644
--- a/Modules/_io/winconsoleio.c
+++ b/Modules/_io/winconsoleio.c
@@ -317,6 +317,7 @@
if (name == NULL)
return -1;
if (console_type == '\0') {
+ PyMem_Free(name);
PyErr_SetString(PyExc_ValueError,
"Cannot open non-console file");
return -1;
@@ -400,7 +401,7 @@
PyErr_SetString(PyExc_ValueError,
"Cannot open non-console file");
goto error;
- }
+ }
if (self->writable && console_type != 'w') {
PyErr_SetString(PyExc_ValueError,
"Cannot open console input buffer for writing");
@@ -428,8 +429,7 @@
internal_close(self);
done:
- if (name)
- PyMem_Free(name);
+ PyMem_Free(name);
return ret;
}