commit 1f9d11b986c95005fbebb724ee3425ad2eb30967
author Serhiy Storchaka <storchaka@gmail.com> Wed Feb 12 09:55:01 2014 +0200
committer Serhiy Storchaka <storchaka@gmail.com> Wed Feb 12 09:55:01 2014 +0200
tree 87b1aceb9935ea8e8943012fa15e698dfd4d3dc3
parent 892f4f9360bf7d8b276f538defe7ab11593efda8

Issue #19255: Clear error after failed PyDict_SetItem() on shutdown.
This silences a Coverity complain.

Objects/moduleobject.c

diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c
index 2f2bd36..72978ae 100644
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -300,7 +300,8 @@
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }
@@ -319,7 +320,8 @@
                     else
                         PyErr_Clear();
                 }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
             }
         }
     }