#5548: do return the new module from PyMODINIT_FUNC functions.
diff --git a/Doc/extending/extending.rst b/Doc/extending/extending.rst
index b035d94..d7f1357 100644
--- a/Doc/extending/extending.rst
+++ b/Doc/extending/extending.rst
@@ -1266,12 +1266,13 @@
{
PyObject *m;
- m = Py_InitModule("client", ClientMethods);
+ m = PyModule_Create(&clientmodule);
if (m == NULL)
- return;
+ return NULL;
if (import_spam() < 0)
- return;
+ return NULL;
/* additional initialization can happen here */
+ return m;
}
The main disadvantage of this approach is that the file :file:`spammodule.h` is
diff --git a/Doc/extending/newtypes.rst b/Doc/extending/newtypes.rst
index c20e96f..83c95f2 100644
--- a/Doc/extending/newtypes.rst
+++ b/Doc/extending/newtypes.rst
@@ -871,6 +871,7 @@
Py_INCREF(&ShoddyType);
PyModule_AddObject(m, "Shoddy", (PyObject *) &ShoddyType);
+ return m;
}
Before calling :cfunc:`PyType_Ready`, the type structure must have the