commit 21fe7213455748fa321333d67e3542848bec9630
author Serhiy Storchaka <storchaka@gmail.com> Tue Jan 03 11:17:44 2017 +0200
committer Serhiy Storchaka <storchaka@gmail.com> Tue Jan 03 11:17:44 2017 +0200
tree c4612da0326389e79bcd09ab78c85c0dd033f7dc
parent d9cb1b0c2d25ac1e368580a14803847688183518

Fixed possible reference leaks in the _json module.

Modules/_json.c

diff --git a/Modules/_json.c b/Modules/_json.c
index f82af34..47c9b0d 100644
--- a/Modules/_json.c
+++ b/Modules/_json.c
@@ -845,14 +845,16 @@
     int kind;
     Py_ssize_t end_idx;
     PyObject *val = NULL;
-    PyObject *rval = PyList_New(0);
+    PyObject *rval;
     Py_ssize_t next_idx;
-    if (rval == NULL)
-        return NULL;
 
     if (PyUnicode_READY(pystr) == -1)
         return NULL;
 
+    rval = PyList_New(0);
+    if (rval == NULL)
+        return NULL;
+
     str = PyUnicode_DATA(pystr);
     kind = PyUnicode_KIND(pystr);
     end_idx = PyUnicode_GET_LENGTH(pystr) - 1;
@@ -1559,8 +1561,11 @@
             return -1;
         }
 
-        if (Py_EnterRecursiveCall(" while encoding a JSON object"))
+        if (Py_EnterRecursiveCall(" while encoding a JSON object")) {
+            Py_DECREF(newobj);
+            Py_XDECREF(ident);
             return -1;
+        }
         rv = encoder_listencode_obj(s, acc, newobj, indent_level);
         Py_LeaveRecursiveCall();