commit 231aad38493c871dd32930a21d256cbacd2ae20c
author Serhiy Storchaka <storchaka@gmail.com> Mon Jun 17 16:57:27 2019 +0300
committer GitHub <noreply@github.com> Mon Jun 17 16:57:27 2019 +0300
tree 93c8e378e647443dcbcbc25b2c35e9052bcbef31
parent 1ce2656f13e726b3b99d4c968926908cff1f460a

bpo-37315: Deprecate accepting floats in math.factorial(). (GH-14147)

Modules/mathmodule.c

diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c
index 82a9a14..a75a3c9 100644
--- a/Modules/mathmodule.c
+++ b/Modules/mathmodule.c
@@ -1981,6 +1981,12 @@
     PyObject *result, *odd_part, *pyint_form;
 
     if (PyFloat_Check(arg)) {
+        if (PyErr_WarnEx(PyExc_DeprecationWarning,
+                         "Using factorial() with floats is deprecated",
+                         1) < 0)
+        {
+            return NULL;
+        }
         PyObject *lx;
         double dx = PyFloat_AS_DOUBLE((PyFloatObject *)arg);
         if (!(Py_IS_FINITE(dx) && dx == floor(dx))) {