commit 27007dccec8ce20ee95e45492643bc1407326abc
author Benjamin Peterson <benjamin@python.org> Wed Jul 06 23:26:32 2016 -0700
committer Benjamin Peterson <benjamin@python.org> Wed Jul 06 23:26:32 2016 -0700
tree bd2ceaadee06abb456997da42416a6e455f0ffdf
parent a1fc45ae73f6c230ffb936db549ec225e19656af

fix refleaks in PyDict_SetItem error cases (closes #27248)

Objects/typeobject.c

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index 317334f..8c5c77e 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -4509,8 +4509,10 @@
         descr = PyDescr_NewMember(type, memb);
         if (descr == NULL)
             return -1;
-        if (PyDict_SetItemString(dict, memb->name, descr) < 0)
+        if (PyDict_SetItemString(dict, memb->name, descr) < 0) {
+            Py_DECREF(descr);
             return -1;
+        }
         Py_DECREF(descr);
     }
     return 0;
@@ -4529,8 +4531,10 @@
 
         if (descr == NULL)
             return -1;
-        if (PyDict_SetItemString(dict, gsp->name, descr) < 0)
+        if (PyDict_SetItemString(dict, gsp->name, descr) < 0) {
+            Py_DECREF(descr);
             return -1;
+        }
         Py_DECREF(descr);
     }
     return 0;
@@ -7010,8 +7014,10 @@
             descr = PyDescr_NewWrapper(type, p, *ptr);
             if (descr == NULL)
                 return -1;
-            if (PyDict_SetItem(dict, p->name_strobj, descr) < 0)
+            if (PyDict_SetItem(dict, p->name_strobj, descr) < 0) {
+                Py_DECREF(descr);
                 return -1;
+            }
             Py_DECREF(descr);
         }
     }