commit 313bda12e8dfe618c6ef2f3681b5ce02409891c8
author Amaury Forgeot d'Arc <amauryfa@gmail.com> Sun Aug 17 21:05:18 2008 +0000
committer Amaury Forgeot d'Arc <amauryfa@gmail.com> Sun Aug 17 21:05:18 2008 +0000
tree e9ffd14d27aef986bcac59f8b153ae8375fe5f1b
parent 37553fdb951e55186428d011a3c79c5ba6289df7

Fix a refleak in bytearray.split and bytearray.rsplit, detected by
   regrtest.py -R:: test_bytes

Objects/bytearrayobject.c

diff --git a/Objects/bytearrayobject.c b/Objects/bytearrayobject.c
index 9ff4458..5ba1f6d 100644
--- a/Objects/bytearrayobject.c
+++ b/Objects/bytearrayobject.c
@@ -2295,8 +2295,11 @@
         PyBuffer_Release(&vsub);
         return NULL;
     }
-    if (n == 1)
-        return split_char(s, len, sub[0], maxsplit);
+    if (n == 1) {
+        list = split_char(s, len, sub[0], maxsplit);
+        PyBuffer_Release(&vsub);
+        return list;
+    }
 
     list = PyList_New(PREALLOC_SIZE(maxsplit));
     if (list == NULL) {
@@ -2527,8 +2530,11 @@
         PyBuffer_Release(&vsub);
         return NULL;
     }
-    else if (n == 1)
-        return rsplit_char(s, len, sub[0], maxsplit);
+    else if (n == 1) {
+        list = rsplit_char(s, len, sub[0], maxsplit);
+        PyBuffer_Release(&vsub);
+        return list;
+    }
 
     list = PyList_New(PREALLOC_SIZE(maxsplit));
     if (list == NULL) {