commit 3152bc36fd1a8ab349d6802e9b48dd88a35b3620
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Wed Aug 22 01:54:33 2018 -0400
committer GitHub <noreply@github.com> Wed Aug 22 01:54:33 2018 -0400
tree 65dfb9d22628724c84b48718aa1401160011ee51
parent 985dcd49cab44bba63ffebe413a9ef17b3da5fa7

bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)


Reported by Svace static analyzer.
(cherry picked from commit f8c06b028036e50596e75d4c9f6b27ba05133efe)

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

Modules/_pickle.c

diff --git a/Modules/_pickle.c b/Modules/_pickle.c
index 40b29a7..fc119c0 100644
--- a/Modules/_pickle.c
+++ b/Modules/_pickle.c
@@ -3452,6 +3452,8 @@
             PickleState *st = _Pickle_GetGlobalState();
             PyObject *reduce_value = Py_BuildValue("(O(OO))",
                                         st->getattr, parent, lastname);
+            if (reduce_value == NULL)
+                goto error;
             status = save_reduce(self, reduce_value, NULL);
             Py_DECREF(reduce_value);
             if (status < 0)