bpo-44304: Ensure the sqlite3 destructor callback is always called with the GIL held (GH-26551) (GH_26552)
(cherry picked from commit 6e3b7cf3af3ed7758b2c2193c1d393feb8ab8f72)
Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
index fccffab..8e42a36 100644
--- a/Modules/_sqlite/connection.c
+++ b/Modules/_sqlite/connection.c
@@ -851,7 +851,12 @@ static void _pysqlite_drop_unused_cursor_references(pysqlite_Connection* self)
static void _destructor(void* args)
{
+ // This function may be called without the GIL held, so we need to ensure
+ // that we destroy 'args' with the GIL
+ PyGILState_STATE gstate;
+ gstate = PyGILState_Ensure();
Py_DECREF((PyObject*)args);
+ PyGILState_Release(gstate);
}
/*[clinic input]