Fix the final two issues in Armin Rigo's SF bug #488477: apply_slice()
and assign_slice() weren't properly DECREF'ing the temporary slice
object they created. (Shame on me. :-)
diff --git a/Python/ceval.c b/Python/ceval.c
index b41ef5a..5358517 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -3398,8 +3398,11 @@
}
else {
PyObject *slice = PySlice_New(v, w, NULL);
- if (slice != NULL)
- return PyObject_GetItem(u, slice);
+ if (slice != NULL) {
+ PyObject *res = PyObject_GetItem(u, slice);
+ Py_DECREF(slice);
+ return res;
+ }
else
return NULL;
}
@@ -3426,10 +3429,13 @@
else {
PyObject *slice = PySlice_New(v, w, NULL);
if (slice != NULL) {
+ int res;
if (x != NULL)
- return PyObject_SetItem(u, slice, x);
+ res = PyObject_SetItem(u, slice, x);
else
- return PyObject_DelItem(u, slice);
+ res = PyObject_DelItem(u, slice);
+ Py_DECREF(slice);
+ return res;
}
else
return -1;