bpo-41520: codeop no longer ignores SyntaxWarning (GH-21838)
diff --git a/Lib/codeop.py b/Lib/codeop.py
index 7e192ea..5476292 100644
--- a/Lib/codeop.py
+++ b/Lib/codeop.py
@@ -84,9 +84,11 @@
except SyntaxError:
pass
- # Suppress warnings after the first compile to avoid duplication.
+ # Catch syntax warnings after the first compile
+ # to emit SyntaxWarning at most once.
with warnings.catch_warnings():
- warnings.simplefilter("ignore")
+ warnings.simplefilter("error", SyntaxWarning)
+
try:
code1 = compiler(source + "\n", filename, symbol)
except SyntaxError as e:
diff --git a/Lib/test/test_codeop.py b/Lib/test/test_codeop.py
index 6e821df6..7984e5f 100644
--- a/Lib/test/test_codeop.py
+++ b/Lib/test/test_codeop.py
@@ -4,6 +4,7 @@
"""
import sys
import unittest
+import warnings
from test import support
from test.support import warnings_helper
@@ -310,5 +311,11 @@
compile_command("0 is 0")
self.assertEqual(len(w.warnings), 1)
+ # bpo-41520: check SyntaxWarning treated as an SyntaxError
+ with self.assertRaises(SyntaxError):
+ warnings.simplefilter('error', SyntaxWarning)
+ compile_command('1 is 1\n', symbol='exec')
+
+
if __name__ == "__main__":
unittest.main()