commit 394dc0db878c08d003772de163a57ac12046d865
author Pablo Galindo <Pablogsal@gmail.com> Tue Mar 03 01:13:10 2020 +0000
committer GitHub <noreply@github.com> Tue Mar 03 01:13:10 2020 +0000
tree 0f7e464fbe56dfeb9a14392795fe45da85fccd57
parent 0d20364b132014eec609b900997c34779a4d548c

[3.8] bpo-39831: Fix a reference leak in PyErr_WarnEx(). (GH-18750) (GH-18761)

(cherry picked from commit 2d2f855)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Python/_warnings.c

diff --git a/Python/_warnings.c b/Python/_warnings.c
index e02d283..87269dd 100644
--- a/Python/_warnings.c
+++ b/Python/_warnings.c
@@ -856,11 +856,11 @@
         int rc;
 
         if (PyErr_Occurred()) {
-            return 0;
+            goto handle_error;
         }
         *registry = PyDict_New();
         if (*registry == NULL)
-            return 0;
+            goto handle_error;
 
          rc = _PyDict_SetItemId(globals, &PyId___warningregistry__, *registry);
          if (rc < 0)
@@ -890,6 +890,7 @@
        dangling reference. */
     Py_XDECREF(*registry);
     Py_XDECREF(*module);
+    Py_XDECREF(*filename);
     return 0;
 }