commit 3b73ea127892d0e1f9d8f12f88e4f9c0ba0b89b1
author Serhiy Storchaka <storchaka@gmail.com> Wed Nov 16 10:19:20 2016 +0200
committer Serhiy Storchaka <storchaka@gmail.com> Wed Nov 16 10:19:20 2016 +0200
tree a1a58a83f9d60f7d5d02e5d116bb76ee13c42254
parent 21060105d99a9153db44dd88eb750965392fd966
parent f4934ea77da38516731a75fbf9458b248d26dd81

Issue #28701: Replace PyUnicode_CompareWithASCIIString with _PyUnicode_EqualToASCIIString.

The latter function is more readable, faster and doesn't raise exceptions.

Modules/_io/textio.c

diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
index dca4ea9..2f55eb0 100644
--- a/Modules/_io/textio.c
+++ b/Modules/_io/textio.c
@@ -1023,7 +1023,7 @@
         else if (PyUnicode_Check(res)) {
             const encodefuncentry *e = encodefuncs;
             while (e->name != NULL) {
-                if (!PyUnicode_CompareWithASCIIString(res, e->name)) {
+                if (_PyUnicode_EqualToASCIIString(res, e->name)) {
                     self->encodefunc = e->encodefunc;
                     break;
                 }

Modules/_io/winconsoleio.c

diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c
index 4666a38..7b00a9e 100644
--- a/Modules/_io/winconsoleio.c
+++ b/Modules/_io/winconsoleio.c
@@ -93,11 +93,11 @@
     }
 
     char m = '\0';
-    if (PyUnicode_CompareWithASCIIString(decoded_upper, "CONIN$") == 0) {
+    if (_PyUnicode_EqualToASCIIString(decoded_upper, "CONIN$")) {
         m = 'r';
-    } else if (PyUnicode_CompareWithASCIIString(decoded_upper, "CONOUT$") == 0) {
+    } else if (_PyUnicode_EqualToASCIIString(decoded_upper, "CONOUT$")) {
         m = 'w';
-    } else if (PyUnicode_CompareWithASCIIString(decoded_upper, "CON") == 0) {
+    } else if (_PyUnicode_EqualToASCIIString(decoded_upper, "CON")) {
         m = 'x';
     }