commit 41c57b335330ff48af098d47e379e0f9ba09d233
author Serhiy Storchaka <storchaka@gmail.com> Sun Sep 01 12:03:39 2019 +0300
committer GitHub <noreply@github.com> Sun Sep 01 12:03:39 2019 +0300
tree 15cdef099182eddb04b2276dc51375b8faf28278
parent f02ea6225bc3b71bd5fe66224d199a6e3e23b14d

bpo-37994: Fix silencing all errors if an attribute lookup fails. (GH-15630)

Only AttributeError should be silenced.

Objects/bytearrayobject.c

diff --git a/Objects/bytearrayobject.c b/Objects/bytearrayobject.c
index 9dd6712..8c16cc6 100644
--- a/Objects/bytearrayobject.c
+++ b/Objects/bytearrayobject.c
@@ -2061,9 +2061,10 @@
     _Py_IDENTIFIER(__dict__);
     char *buf;
 
-    dict = _PyObject_GetAttrId((PyObject *)self, &PyId___dict__);
+    if (_PyObject_LookupAttrId((PyObject *)self, &PyId___dict__, &dict) < 0) {
+        return NULL;
+    }
     if (dict == NULL) {
-        PyErr_Clear();
         dict = Py_None;
         Py_INCREF(dict);
     }