commit 49fb49d6f57661f2a7601f1d759163866f707fed
author Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com> Sat Oct 06 00:07:12 2018 -0700
committer GitHub <noreply@github.com> Sat Oct 06 00:07:12 2018 -0700
tree de417343fa2f5061f13a15d650e9abcdd4339de2
parent 0991b9bb94036e0f271d223c8db7d81980c76736

bpo-34910: Ensure that PyObject_Print() always returns -1 on error. (GH-9733)

(cherry picked from commit ae62f015240c9162773341a9922794e6b960779d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Objects/object.c

diff --git a/Objects/object.c b/Objects/object.c
index 220aa90..5535b7e 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -376,8 +376,9 @@
             else if (PyUnicode_Check(s)) {
                 PyObject *t;
                 t = PyUnicode_AsEncodedString(s, "utf-8", "backslashreplace");
-                if (t == NULL)
-                    ret = 0;
+                if (t == NULL) {
+                    ret = -1;
+                }
                 else {
                     fwrite(PyBytes_AS_STRING(t), 1,
                            PyBytes_GET_SIZE(t), fp);