commit 4c596d54aa6a55e9d2a3db78891e656ebbfb63c8
author Zackery Spytz <zspytz@gmail.com> Wed Nov 14 15:39:01 2018 -0700
committer Serhiy Storchaka <storchaka@gmail.com> Thu Nov 15 00:39:01 2018 +0200
tree 2f39bae0ddccf5eb6696af1a030dd9fa227bb3d4
parent 01de89cb59107d4f889aa503a1c0350dae4aebaf

Fix a possible reference leak in _socket.getaddrinfo(). (GH-10543)

"single" needs to be decrefed if PyList_Append() fails.

Modules/socketmodule.c

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index 9149641..a47f031 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -6370,9 +6370,11 @@
         if (single == NULL)
             goto err;
 
-        if (PyList_Append(all, single))
+        if (PyList_Append(all, single)) {
+            Py_DECREF(single);
             goto err;
-        Py_XDECREF(single);
+        }
+        Py_DECREF(single);
     }
     Py_XDECREF(idna);
     if (res0)