commit 5327f370344a627f1578d8183d197feb286371c6
author Zackery Spytz <zspytz@gmail.com> Wed Jan 27 01:16:20 2021 -0700
committer GitHub <noreply@github.com> Wed Jan 27 10:16:20 2021 +0200
tree 675f71f86e45a666032875fc74877836625c6b14
parent 7a34380ad788886f5ad50d4175ceb2d5715b8cff

bpo-43033: Fix the handling of PyObject_SetAttrString() in _zoneinfo.c (GH-24345)

Modules/_zoneinfo.c

diff --git a/Modules/_zoneinfo.c b/Modules/_zoneinfo.c
index d1e0934..4a4cbdb 100644
--- a/Modules/_zoneinfo.c
+++ b/Modules/_zoneinfo.c
@@ -2525,7 +2525,11 @@ zoneinfo_init_subclass(PyTypeObject *cls, PyObject *args, PyObject **kwargs)
         return NULL;
     }
 
-    PyObject_SetAttrString((PyObject *)cls, "_weak_cache", weak_cache);
+    if (PyObject_SetAttrString((PyObject *)cls, "_weak_cache",
+                               weak_cache) < 0) {
+        Py_DECREF(weak_cache);
+        return NULL;
+    }
     Py_DECREF(weak_cache);
     Py_RETURN_NONE;
 }