commit 55087f0c351d6de453a5c95293792051d899f16b
author Jeremy Hylton <jeremy@alum.mit.edu> Mon Jan 29 22:46:35 2001 +0000
committer Jeremy Hylton <jeremy@alum.mit.edu> Mon Jan 29 22:46:35 2001 +0000
tree ece917fd15c87c96d466be0c937021904f977199
parent 2fdfadf6dd796c0a9a467c8800eaa501b0407908

Cleanup logic a little.  Check args first, then try to create the
object.  This avoids creation + decref if bogus arguments are passed.

Modules/shamodule.c

diff --git a/Modules/shamodule.c b/Modules/shamodule.c
index 32ac02d..8bfcec7 100644
--- a/Modules/shamodule.c
+++ b/Modules/shamodule.c
@@ -491,16 +491,15 @@
     SHAobject *new;
     unsigned char *cp = NULL;
     int len;
-	
-    if ((new = newSHAobject()) == NULL)
-        return NULL;
 
     if (!PyArg_ParseTupleAndKeywords(args, kwdict, "|s#:new", kwlist,
                                      &cp, &len)) {
-        Py_DECREF(new);
         return NULL;
     }
 
+    if ((new = newSHAobject()) == NULL)
+        return NULL;
+
     sha_init(new);
 
     if (PyErr_Occurred()) {