bpo-40670: More reliable validation of statements in timeit.Timer. (GH-22358)
It now accepts "empty" statements (only whitespaces and comments)
and rejects misindentent statements.
diff --git a/Lib/test/test_timeit.py b/Lib/test/test_timeit.py
index e02d4a7..72a104f 100644
--- a/Lib/test/test_timeit.py
+++ b/Lib/test/test_timeit.py
@@ -77,6 +77,9 @@
self.assertRaises(SyntaxError, timeit.Timer, stmt='break')
self.assertRaises(SyntaxError, timeit.Timer, stmt='continue')
self.assertRaises(SyntaxError, timeit.Timer, stmt='from timeit import *')
+ self.assertRaises(SyntaxError, timeit.Timer, stmt=' pass')
+ self.assertRaises(SyntaxError, timeit.Timer,
+ setup='while False:\n pass', stmt=' break')
def test_timer_invalid_setup(self):
self.assertRaises(ValueError, timeit.Timer, setup=None)
@@ -86,6 +89,12 @@
self.assertRaises(SyntaxError, timeit.Timer, setup='break')
self.assertRaises(SyntaxError, timeit.Timer, setup='continue')
self.assertRaises(SyntaxError, timeit.Timer, setup='from timeit import *')
+ self.assertRaises(SyntaxError, timeit.Timer, setup=' pass')
+
+ def test_timer_empty_stmt(self):
+ timeit.Timer(stmt='')
+ timeit.Timer(stmt=' \n\t\f')
+ timeit.Timer(stmt='# comment')
fake_setup = "import timeit\ntimeit._fake_timer.setup()"
fake_stmt = "import timeit\ntimeit._fake_timer.inc()"